Bug 2060541 - Recheck auth status on startup, weekly

[bytesized]

Pull Request checklist

• Breaking changes: This PR follows our breaking change policy
  • This PR follows the breaking change policy:
    • This PR has no breaking API changes
• Quality: This PR builds and tests run cleanly
  • cargo test succeeds locally.
• Tests: This PR includes thorough tests or an explanation of why it does not
  • No automated testing, but this adds the cargo fxa force-auth-issues command to the example CLI client in order to be able to test this manually.
• Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
  • This change is small enough that it doesn't seem like it warrants a changelog entry.
• Dependencies: This PR follows our dependency management guidelines
  • No new dependencies added.

[bytesized]

I have been thinking a fair amount about the part of this patch that I'm the least sure about: the part in components/fxa-client/src/state_machine/mod.rs where we avoid calling on_auth_issues() on the Uninitialized -> AuthIssues transition. When I wrote it, I felt reasonably sure that this change wouldn't have any negative effects because that state transition should only happen after we already transitioned to AuthIssues and because the effects of on_auth_issues should persist through the next initialization. But having thought about it a bit more, I believe that there are ways of having the Uninitialized -> AuthIssues transition without having previously been in the AuthIssues state. So I think I may have to undo that change. But I'm not sure of the correct way to address the issue that it always runs on_auth_issues when we start up in the AuthIssues state, resetting the last_auth_recheck_time timer. I'm going to have to think about this.

[bytesized]

I ended up not putting the logic to reset the auth timer in on_auth_issues() because of the issue I discussed above. To summarize, we always call on_auth_issues() on the Uninitialized to AuthIssues transition which causes the recheck to never happen since we never see an expired timer. But this means that I've basically littered the transition() function with account.reset_auth_recheck_timer() calls. Which doesn't feel great since it makes maintenance of this function kinda nasty. I'm not sure what a better option is but I'm open to ideas.

[bendk]

This is looking very good. Thanks for updating the example client.

I had a couple suggestions, but the only blocker is figuring out how we should store the refresh token when we're in the auth-issues state.

The pull request has been modified, dismissing previous reviews.

[bendk]

The changes look great. The last part is updating the methods I noted so that they continue to throw a NoRefreshToken error if logged_out_from_auth_issues=true.

The pull request has been modified, dismissing previous reviews.