Update iOS docs for adding a Rust component; install Apple silicon iOS Simulator target. [ci full] #5322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix the path to `MozillaTestServices.xcodeproj`. * Clarify that the generated bindings for the component should be added after the UDL file. When adding a UniFFIed component for the first time, the `Generated` subdirectory won't exist until after the UDL file has been added to the project, _and_ Xcode has run `uniffi_bindgen` to generate the `.swift` file. * Add a note to double-check that the new `.udl` file is _not_ added as a bundle resource (it should be added as a source), and the generated `.swift` file isn't added at all. Xcode's "add files" dialog likes to add files to a target, which will cause a cryptic build cycle error in this case. * The "Headers" phase has been removed; it looks like it's not necessary to add `<your_crate_name>FFI.h` to the list of Public headers anymore. * Fix the module name for tests.
We currently install the Intel iOS Simulator target, but not the Apple silicon iOS Simulator target. Without the latter, `build-xcframework.sh` can't build the framework on an M1 Mac.
Codecov ReportBase: 46.91% // Head: 46.91% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #5322 +/- ##
=======================================
Coverage 46.91% 46.91%
=======================================
Files 180 180
Lines 14474 14474
=======================================
Hits 6791 6791
Misses 7683 7683 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tarikeshaq
previously approved these changes
Jan 10, 2023
|
Yaaay thank you so much for the speedy review, @tarikeshaq! 🙏🏼 |
mergify
bot
dismissed
tarikeshaq’s stale review
The pull request has been modified, dismissing previous reviews.
tarikeshaq
approved these changes
Jan 10, 2023
|
I'll land this as long as the required CI passes, no need for the android builds to run! I'll also get @linabutler added to the github team that prevents mergify from dismissing reviews and allows landing PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋🏼 I went through the (fantastic! 🤩) instructions for adding a Rust component, and updated the ones for iOS based on my experience. (I also had to install the
aarch64-apple-ios-simtarget on my M1 Mac, or the framework wouldn't build at all). Please take a look whenever it's convenient, thanks!Rendered view
(No changes to the code, but I added
[ci full]just in case, since I did change the CI bootstrapping script).Pull Request checklist
[ci full]to the PR title.Branch builds: add
[ff-android: firefox-android-branch-name]and/or[fenix: fenix-branch-name]to the PR title.