Allow M1 building & testing via arm64 JDK #4898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4898 +/- ##
=======================================
Coverage 38.46% 38.46%
=======================================
Files 166 166
Lines 12353 12353
=======================================
Hits 4751 4751
Misses 7602 7602 Continue to review full report at Codecov.
|
skhamis
force-pushed
the
m1-android-taskcluster
branch
from
74460d7 to
43bd433
Compare
skhamis
force-pushed
the
m1-android-taskcluster
branch
from
43bd433 to
83cfef1
Compare
skhamis
changed the title
skhamis
force-pushed
the
m1-android-taskcluster
branch
from
83cfef1 to
2717822
Compare
skhamis
changed the title
|
@skhamis Is this ready to land? |
Hey Ryan, I haven't been able to run the full test just yet (I need to make sure arm64 jdk compiles & tests all the way up to fenix) but I should be able to soon! |
skhamis
force-pushed
the
m1-android-taskcluster
branch
from
2717822 to
989caec
Compare
|
Sorry, I don't think I'm in a position to meaningfully review this. |
skhamis
force-pushed
the
m1-android-taskcluster
branch
from
989caec to
c7f25ec
Compare
lougeniaC64
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
@skhamis I'm giving this a rubber stamp approval because I can't test this (yet). Sorry for the delay. I think I saw that you closed this a while back and dismissed it. 🫣
skhamis
force-pushed
the
m1-android-taskcluster
branch
from
c7f25ec to
b39ccdc
Compare
bendk
added a commit
to bendk/application-services
that referenced
this pull request
Oct 12, 2022
This reverts commit 15b00bf.
bendk
pushed a commit
to bendk/application-services
that referenced
this pull request
Oct 17, 2022
update cross compile tool for M1 macs
bendk
pushed a commit
to bendk/application-services
that referenced
this pull request
Oct 17, 2022
update cross compile tool for M1 macs
bendk
pushed a commit
to bendk/application-services
that referenced
this pull request
Oct 17, 2022
update cross compile tool for M1 macs
bendk
pushed a commit
to bendk/application-services
that referenced
this pull request
Oct 17, 2022
update cross compile tool for M1 macs
bendk
pushed a commit
to bendk/application-services
that referenced
this pull request
Oct 17, 2022
update cross compile tool for M1 macs
bendk
pushed a commit
to bendk/application-services
that referenced
this pull request
Oct 17, 2022
update cross compile tool for M1 macs
bendk
pushed a commit
to bendk/application-services
that referenced
this pull request
Oct 18, 2022
update cross compile tool for M1 macs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
[ci full]to the PR title.