-
Notifications
You must be signed in to change notification settings - Fork 230
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug 1898509 - more details for SQL errors
The goal here is to track down some foreign key failures that we're seeing, but don't have any context on where they're happening. - Record a breadcrumb when we start to ingest different suggestion types. - Record what we were doing when we saw an SQL error. This should change the message from `FOREIGN KEY constraint failed` to something like `FOREIGN KEY constraint failed (context: mdn insert)`, which I think will help greatly. I wanted to also record which field the foreign key error was happening on, but AFAICT this is not possible with SQLite. I added the `extend` crate to help with some of this code. It's not really needed, but I think it's worth the dependency. We've been using it for `uniffi-bindgen-gecko-js` so it's already vetted.
- Loading branch information
Showing
9 changed files
with
281 additions
and
127 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.