[Bug]: Holding a disable action in 2nd level approval doesn't clear NHR #16041
Description
Is there an existing issue for this?
- I have searched the existing issues
What happened?
Follow-on from #15940 - essentially, we don't clear NHR when we trigger a force disable from the reviewer tools, delegating it instead to the force_disable method. But this means that if a decision is held for 2nd level approval the NHR isn't cleared. The add-on would stay in the queue; and additionally if the decision is requeued the requeue action would normally create a new NHR, but the code purposely doesn't create duplicate NHRs if one already exists, so no new NHR means no activity log to attach comments to.
What did you expect to happen?
NHR is cleared when a decision is held for 2nd level approval
┆Issue is synchronized with this Jira Task