Skip to content

[Bug]: Review page shows incorrect version review information for rolled back version #16040

@abhn

Description

@abhn

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

For an add-on that

  • Has multiple versions (say, v1, v2, v3)
  • v1 and v2 were auto-approved, not confirmed
  • Developer rolled back from v2 to v1 that resulted in v3 being created

When the reviewer looks at the reviewer actions that show all of the add-on's versions (such as "Reject multiple versions"), the version list shows "Manual" for a version that's a rolled-back version.

In case of my example above, v3 would show as "Approved, Manual" even if v3 (or, v1 that it rolled back to) was never manually approved.

What did you expect to happen?

Following my example above, v3 should state the version information as the same as the version it rolled back to, which in this case should be "Auto-approved, not Confirmed"

In the list below, for add-on 2927886, there are two "Approved, Manual" versions when the add-on has never been reviewed or approved manually.

Image

┆Issue is synchronized with this Jira Task

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions