[Bug]: 2nd-level approval queue: "Cancel and enqueue" does not enqueue

[wagnerand]

What happened?

The "Cancel and enqueue in Reviewer Tools" action in the 2nd-level approval queue does not seem to enqueue the version if it's unlisted.

STR:

1. Submit an unlisted update to a e.g. promoted add-on (to make sure high-impact decisions will be held)
2. Wait for the unlisted version to be auto-approved, or as a reviewer, approve it manually (e.g. for promoted add-ons)
3. As a reviewer, delay-reject the unlisted version
4. As a 2nd-level approver, click "Cancel and enqueue in Reviewer Tools"

Result:
The entry is gone from the 2nd level approval queue (=decision canceled), but the version is not enqueued in the regular review queue.

What did you expect to happen?

The version is enqueued in the regular review queue.

Is there an existing issue for this?

• I have searched the existing issues

┆Issue is synchronized with this Jira Task

[eviljeff]

This is because, if we can't find a version to flag (which generally comes from abuse reports attached to the job), we fallback to addon.current_version, which isn't a thing if there are only unlisted versions on the add-on.

Possible solutions:

• fall back to the latest version for (unlisted only?) add-ons
• use the target versions from the decision that triggered the second level approval (this is the solution - but the first one might be useful too?)

[wagnerand]

Let's do the following:

use the target versions from the decision that triggered the second level approval

If an staff person also wants the latest version to be reviewed, they can flag it for review manually.

[eviljeff]

@wagnerand I was going to start work on this but I believe #15568 make this redundant as unlisted rejections no longer fit the criteria for 2nd level approval?

[wagnerand]

@wagnerand I was going to start work on this but I believe #15568 make this redundant as unlisted rejections no longer fit the criteria for 2nd level approval?

Ah good catch, that sounds right, thank you!