Generate service accounts when registering scanner webhooks #24325
+260
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdurand
force-pushed
the
service-account
branch
2 times, most recently
from
5a546a6 to
a2da4eb
Compare
willdurand
commented
Jan 14, 2026
willdurand
force-pushed
the
service-account
branch
from
a2da4eb to
2163a86
Compare
willdurand
force-pushed
the
service-account
branch
from
2163a86 to
198ee61
Compare
diox
reviewed
Jan 19, 2026
diox
requested changes
Jan 19, 2026
| @@ -256,6 +257,21 @@ class ScannerWebhook(ModelBase): | |||
| class Meta: | |||
| db_table = 'scanners_webhooks' | |||
|
|
|||
| def save(self, *args, **kwargs): | |||
| UserProfile.objects.get_or_create_service_account( | |||
Member
There was a problem hiding this comment.
Should we also automatically delete it if the ScannerWebhook gets deleted ?
Member
Author
There was a problem hiding this comment.
Good question. I didn't link scanner webhooks with UserProfile precisely to not have to delete the accounts when the ScannerWebhook is deleted but I am wondering if this is good. Though, my approach to this would be to keep things simple for now, and iterate.
willdurand
force-pushed
the
service-account
branch
from
09bc9cd to
e952968
Compare
Member
Author
|
Updated! |
diox
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#15944
While this creates a service account automatically (with JWT/AMO API
keys), configuring the groups/permissions remains a manual process
because every service is going to be different.