process override decision payloads from webhook without cinder job #22829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15144
Description
Expands the cinder decision webhook to handle payloads where there is no cinder job id, but there is a reference to the previous decision, so we can get the job from there.
Context
I'm sure overrides on decisions on jobs used to send the original job id too, but either way, it doesn't now. As we track decision ids we can follow the fk on the ContentDecision back to the CinderJob.
Testing
Difficult because requires the webhook payload to be replayed via curl, etc. (as usual, you may want to comment out the auth in the view to make it easier)
Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.