Show Pastebin Attachment if File/Input Already Uploaded #22813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrstinalin
requested review from
a team and
KevinMind
and removed request for
a team
KevinMind
reviewed
Nov 1, 2024
| }); | ||
| }; | ||
|
|
||
| $('#id_attachment_file').prop('files').length && showFileWrapper(); |
There was a problem hiding this comment.
My jquery days are long gone but my understanding is this code will execute one time on page load, or when that element is in the dom? It's not totally clear since there is no explicit event trigger. Is it possible to do that somehow or maybe add a comment indicating when this code is/should be executed?
There was a problem hiding this comment.
Once on page load, yeah -- initExtraReviewActions() is called on document ready.
I could add a comment, but it feels like something that would really be relevant to the entire function rather than a comment singling out this particular line within it?
KevinMind
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15105
Description
Makes it clearer that a file or text is still attached to an action and prevent defaulting to the initial menu.
Testing
enable-activity-log-attachmentsChecklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.