Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachment Emails for Reviewer Attachments #22704

Merged
merged 8 commits into from
Sep 27, 2024

Conversation

chrstinalin
Copy link
Contributor

Fixes: mozilla/addons#15018

Description

Include the existence of attachments for emails associated with reviewer actions outside of replies.

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.

Copy link

sentry-io bot commented Sep 25, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/olympia/abuse/models.py

Function Unhandled Issue
notify_reviewer_decision ConnectionError: b'\n<!doctype html>\n\n\n <title>Server Error (500)</title>\n\n<bod... ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@chrstinalin chrstinalin changed the title #15018 email actions Attachment Emails for Reviewer Attachments Sep 25, 2024
@chrstinalin chrstinalin requested review from a team and eviljeff and removed request for a team September 26, 2024 12:59
Copy link
Member

@eviljeff eviljeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc just some minor tweaks

@chrstinalin chrstinalin merged commit 3ab810b into mozilla:master Sep 27, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Pastebin - Include link to any attachment in any action
2 participants