CI: Only run push locales on push events #22589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diox
reviewed
Aug 22, 2024
diox
approved these changes
Aug 22, 2024
KevinMind
added a commit
that referenced
this pull request
Aug 22, 2024
* CI: Only run push locales on push events * TMP: also run push on pull requests * TMP: revert the push check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of failled deployment: https://github.com/mozilla/addons-server/actions/runs/10505053101
Context
Currently our CI runs a locales job that extracts locales and runs the push locales command. On non master push it was running in dry mode and for any tag based from master this would be fine as it would include the automatically extracted locale strings.
But.... if you cherry pick a commit without cherry picking the extracted locales... then they are missing and locale job tries to push new strings.
This fails because we are on a detached head. There is no reason to run the push job at all on any event other than push so we can just avoid this class of bugs entirely.
We did NOT see this before because we didn't run any CI on tags before deploying them previously.
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.