Render diffs in Compare page #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
+ Coverage 96.97% 97.02% +0.04%
==========================================
Files 35 35
Lines 662 673 +11
Branches 148 152 +4
==========================================
+ Hits 642 653 +11
+ Misses 19 18 -1
- Partials 1 2 +1
Continue to review full report at Codecov.
|
Merged
willdurand
force-pushed
the
render-diff
branch
9 times, most recently
from
34ac4cf
to
34b1c08
Compare
|
This is also ready :) |
|
rebased! |
kumar303
reviewed
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #292
⚠️ depends on #374
Fixes #362
This patch adds the logic for rendering diffs between two versions of an add-on. It handles errors and loading state.
Gif