Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View diff between two versions #111

Closed
kumar303 opened this issue Feb 1, 2019 · 1 comment · Fixed by #391
Closed

View diff between two versions #111

kumar303 opened this issue Feb 1, 2019 · 1 comment · Fixed by #391
Assignees
@willdurand
Labels
priority:mvp priority:p3 state:pull_request_ready type:feature
Milestone
2019.03.21

Comments

@kumar303
Copy link
Contributor

kumar303 commented Feb 1, 2019

User story:

As a code reviewer, I want to be able to view the source code diff between any two versions of an add-on I’m reviewing.

Here's an example of looking at the diff between version 1.69.0 and 1.69.1 of LastPass. URL: https://reviewers.addons-dev.allizom.org/en-US/firefox/files/compare/93833...93882/

screenshot 2019-02-01 15 31 09
@EnTeQuAk
Copy link

EnTeQuAk commented Feb 7, 2019

Not necessarily blocked by, but the version-chooser component needs mozilla/addons#6327 to be done first. (working on it).

@willdurand willdurand mentioned this issue Feb 22, 2019
Merged
This was referenced Feb 25, 2019
Closed
Closed
Closed
Closed
This was referenced Mar 4, 2019
Closed
Closed
@willdurand willdurand self-assigned this Mar 7, 2019
@willdurand willdurand added this to the 2019.03.14 milestone Mar 7, 2019
This was referenced Mar 7, 2019
Merged
Merged
Closed
Closed
Closed
Closed
Open
Closed
Merged
@willdurand willdurand mentioned this issue Mar 12, 2019
Merged
@willdurand willdurand modified the milestones: 2019.03.14, 2019.03.21 Mar 13, 2019
@willdurand willdurand mentioned this issue Mar 13, 2019
Closed
@willdurand willdurand mentioned this issue Mar 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willdurand willdurand

Labels
priority:mvp priority:p3 state:pull_request_ready type:feature
Projects
None yet
Milestone
2019.03.21
Development

Successfully merging a pull request may close this issue.

VersionChooser can now select versions mozilla/addons-code-manager
3 participants
@kumar303 @EnTeQuAk @willdurand