Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a VersionChooser component for the compare page #293

Closed
willdurand opened this issue Feb 27, 2019 · 7 comments
Closed

Create a VersionChooser component for the compare page #293

willdurand opened this issue Feb 27, 2019 · 7 comments

Comments

@willdurand
Copy link
Member

In order to ship mozilla/addons-server#111, we need a version chooser that relies on this API patch: mozilla/addons#6327.

See screenshot below:

@kumar303
Copy link
Contributor

This also gives us an opportunity to talk with reviewers and figure out their wishes for how to select versions. The old dropboxes were confusing (to me, anyway) so I don't think we should replicate them as is.

@willdurand
Copy link
Member Author

This also gives us an opportunity to talk with reviewers and figure out their wishes for how to select versions. The old dropboxes were confusing (to me, anyway) so I don't think we should replicate them as is.

/cc @mozilla/add-on-admin-reviewers

@wagnerand
Copy link
Member

The thing most confusing about selecting versions was that the newer one has to be selected in the left dropdown. But after a while, I got used to the flow. Maybe just flipping the two is enough?

I am open to other approaches. I'd be interested to hear what was confusing for you @kumar303.

@kumar303
Copy link
Contributor

The thing that's most confusing about selecting versions was that the newer one has to be selected in the left dropdown.

Yeah, I agree

I'd be interested to hear what was confusing for you

For someone new to the UI, it doesn't make a lot of sense. For example:

  • What does the Go button do?
  • What is the meaning of the left dropdown? What's the meaning of the right?
  • What does it mean to select a high version on the left and a lower version on the right or vice versa?
  • Why is the right version grayed out sometimes?

I know the answer to some of these questions but I think the UI could be a lot more intuitive while still keeping it simple and concise.

@willdurand
Copy link
Member Author

Could it be similar to the GitHub compare page?

@willdurand willdurand self-assigned this Feb 28, 2019
@wagnerand
Copy link
Member

* Why is the right version grayed out sometimes?

Hah, I don't definitely know the answer to that one. I could guess...

All good points, thanks!

@willdurand
Copy link
Member Author

willdurand commented Feb 28, 2019

Very first prototype:

screen shot 2019-02-28 at 16 45 04
screen shot 2019-02-28 at 16 45 39
screen shot 2019-02-28 at 16 47 00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants