Skip to content
This repository has been archived by the owner on Aug 4, 2022. It is now read-only.

Commit

Permalink
Bug 1271075: Sites on the new tab page opened with middle click in e1…
Browse files Browse the repository at this point in the history
…0s should have a 'referrerURI'. r=ursulasarracini
  • Loading branch information
Marina Samuel committed Jul 5, 2016
1 parent 89f576d commit fa70574
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 1 deletion.
2 changes: 1 addition & 1 deletion browser/base/content/browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -2967,7 +2967,7 @@ var BrowserOnClick = {
anchorTarget.classList.contains("newtab-link")) {
event.preventDefault();
let where = whereToOpenLink(event, false, false);
openLinkIn(anchorTarget.href, where, { charset: ownerDoc.characterSet });
openLinkIn(anchorTarget.href, where, { charset: ownerDoc.characterSet, referrerURI: ownerDoc.documentURIObject });
}
},

Expand Down
1 change: 1 addition & 0 deletions browser/base/content/test/newtab/browser.ini
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ support-files =
[browser_newtab_bug1145428.js]
[browser_newtab_bug1178586.js]
[browser_newtab_bug1194895.js]
[browser_newtab_bug1271075.js]
[browser_newtab_disable.js]
[browser_newtab_drag_drop.js]
[browser_newtab_drag_drop_ext.js]
Expand Down
32 changes: 32 additions & 0 deletions browser/base/content/test/newtab/browser_newtab_bug1271075.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
/* Any copyright is dedicated to the Public Domain.
http://creativecommons.org/publicdomain/zero/1.0/ */

add_task(function* () {
is(gBrowser.tabs.length, 1, "one tab is open initially");

// Add a few tabs.
let tabs = [];
function addTab(aURL, aReferrer) {
let tab = gBrowser.addTab(aURL, {referrerURI: aReferrer});
tabs.push(tab);
return BrowserTestUtils.browserLoaded(tab.linkedBrowser);
}

yield addTab("http://mochi.test:8888/#0");
yield addTab("http://mochi.test:8888/#1");
yield addTab("http://mochi.test:8888/#2");
yield addTab("http://mochi.test:8888/#3");

// Create a new tab page with a "www.example.com" tile and move it to the 2nd tab position.
yield setLinks("-1");
yield* addNewTabPageTab();
gBrowser.moveTabTo(gBrowser.selectedTab, 1);

// Send a middle-click and confirm that the clicked site opens immediately next to the new tab page.
yield BrowserTestUtils.synthesizeMouseAtCenter(".newtab-cell",
{button: 1}, gBrowser.selectedBrowser);

yield BrowserTestUtils.browserLoaded(gBrowser.getBrowserAtIndex(2));
is(gBrowser.getBrowserAtIndex(2).currentURI.spec, "http://example.com/",
"Middle click opens site in a new tab immediately to the right.");
});

0 comments on commit fa70574

Please sign in to comment.