Bug 1489355 - Windows installer build fixes r=Callek

Bug 1484264 made changes to how the repackage tasks is configured.
The package-name field was hard-coded to "firefox". This field is later
used to build the Windows installer, and Thunderbird requires that it
be set to "thunderbird" or the build fails.

This patch changes package-name to be a templated field like the others.

Differential Revision: https://phabricator.services.mozilla.com/D5222

taskcluster/taskgraph/transforms/repackage.py

@@ -82,7 +82,7 @@
 
 # The configuration passed to the mozharness repackage script. This defines the
 # arguments passed to `mach repackage`
-# - `args` is interpolated by mozharness (`{installer-tag}`,
+# - `args` is interpolated by mozharness (`{package-name}`, `{installer-tag}`,
 #   `{stub-installer-tag}`, `{sfx-stub}`) with values from the mozharness
 #   config.
 # - `inputs` are passed as long-options, with the filename prefixed by
@@ -117,7 +117,7 @@
     'installer': {
         'args': [
             "installer",
-            "--package-name", "firefox",
+            "--package-name", "{package-name}",
             "--tag", "{installer-tag}",
             "--sfx-stub", "{sfx-stub}",
         ],

testing/mozharness/configs/repackage/base.py

@@ -1,4 +1,5 @@
 config = {
+    "package-name": "firefox",
     "installer-tag": "browser/installer/windows/app.tag",
     "stub-installer-tag": "browser/installer/windows/stub.tag",
     "sfx-stub": "other-licenses/7zstub/firefox/7zSD.sfx",

testing/mozharness/scripts/repackage.py

@@ -65,6 +65,7 @@ def repackage(self):
         dirs = self.query_abs_dirs()
 
         subst = {
+            'package-name': config['package-name'],
             'sfx-stub': config['sfx-stub'],
             'installer-tag': config['installer-tag'],
             'stub-installer-tag': config['stub-installer-tag'],