Bug 1197146: Part 4: Use dispatcher for listener isElementSelected

r=dburns
mozilla-spidermonkey · Aug 21, 2015 · cb380e2 · cb380e2
1 parent ffa7008
commit cb380e2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 12 deletions.
diff --git a/testing/marionette/driver.js b/testing/marionette/driver.js
@@ -2172,7 +2172,7 @@ GeckoDriver.prototype.isElementSelected = function(cmd, resp) {
       break;
 
     case Context.CONTENT:
-      resp.value = yield this.listener.isElementSelected({id: id});
+      resp.value = yield this.listener.isElementSelected(id);
       break;
   }
 };

diff --git a/testing/marionette/listener.js b/testing/marionette/listener.js
@@ -207,6 +207,7 @@ let isElementEnabledFn = dispatch(isElementEnabled);
 let getCurrentUrlFn = dispatch(getCurrentUrl);
 let findElementContentFn = dispatch(findElementContent);
 let findElementsContentFn = dispatch(findElementsContent);
+let isElementSelectedFn = dispatch(isElementSelected);
 
 /**
  * Start all message listeners
@@ -241,7 +242,7 @@ function startListeners() {
   addMessageListenerId("Marionette:getElementSize", getElementSizeFn);  // deprecated
   addMessageListenerId("Marionette:getElementRect", getElementRectFn);
   addMessageListenerId("Marionette:isElementEnabled", isElementEnabledFn);
-  addMessageListenerId("Marionette:isElementSelected", isElementSelected);
+  addMessageListenerId("Marionette:isElementSelected", isElementSelectedFn);
   addMessageListenerId("Marionette:sendKeysToElement", sendKeysToElement);
   addMessageListenerId("Marionette:getElementLocation", getElementLocation); //deprecated
   addMessageListenerId("Marionette:clearElement", clearElement);
@@ -346,7 +347,7 @@ function deleteSession(msg) {
   removeMessageListenerId("Marionette:getElementSize", getElementSizeFn); // deprecated
   removeMessageListenerId("Marionette:getElementRect", getElementRectFn);
   removeMessageListenerId("Marionette:isElementEnabled", isElementEnabledFn);
-  removeMessageListenerId("Marionette:isElementSelected", isElementSelected);
+  removeMessageListenerId("Marionette:isElementSelected", isElementSelectedFn);
   removeMessageListenerId("Marionette:sendKeysToElement", sendKeysToElement);
   removeMessageListenerId("Marionette:getElementLocation", getElementLocation);
   removeMessageListenerId("Marionette:clearElement", clearElement);
@@ -1589,18 +1590,16 @@ function isElementEnabled(id) {
 }
 
 /**
- * Check if element is selected
+ * Determines if the referenced element is selected or not.
+ *
+ * This operation only makes sense on input elements of the Checkbox-
+ * and Radio Button states, or option elements.
  */
-function isElementSelected(msg) {
-  let command_id = msg.json.command_id;
-  try {
-    let el = elementManager.getKnownElement(msg.json.id, curFrame);
+function isElementSelected(id) {
+  let el = elementManager.getKnownElement(id, curFrame);
     let selected = utils.isElementSelected(el);
     checkSelectedAccessibility(accessibility.getAccessibleObject(el), selected);
-    sendResponse({value: selected}, command_id);
-  } catch (e) {
-    sendError(e, command_id);
-  }
+  return selected;
 }
 
 /**
-Original file line number
+Diff line change
@@ Expand Up @@
           break;
         case Context.CONTENT:
-          resp.value = yield this.listener.isElementSelected({id: id});
+          resp.value = yield this.listener.isElementSelected(id);
           break;
       }
     };
@@ Expand Down @@