Skip to content
This repository has been archived by the owner on Aug 4, 2022. It is now read-only.

Commit

Permalink
Bug 1272513 - Part 2: Remove redundant -Wshadow CXXFLAGS from moz.bui…
Browse files Browse the repository at this point in the history 
…ld files. r=glandium
  • Loading branch information
@cpeterso
cpeterso committed May 14, 2016
1 parent 9b04c93 commit c15b825
Show file tree
Hide file tree
Showing 221 changed files with 3 additions and 670 deletions.
3 changes: 0 additions & 3 deletions accessible/windows/ia2/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ LOCAL_INCLUDES += [

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']

# The Windows MIDL code generator creates things like:
#
# #endif !_MIDL_USE_GUIDDEF_
Expand Down
3 changes: 0 additions & 3 deletions accessible/windows/msaa/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,3 @@ if CONFIG['CLANG_CL']:
include('/ipc/chromium/chromium-config.mozbuild')

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions accessible/windows/sdn/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,3 @@ LOCAL_INCLUDES += [
]

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions accessible/windows/uia/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,3 @@ LOCAL_INCLUDES += [
]

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions b2g/app/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,6 @@ if CONFIG['OS_ARCH'] == 'WINNT':
'version',
]

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']

JS_PREFERENCE_PP_FILES += [
'b2g.js',
]
Expand Down
3 changes: 0 additions & 3 deletions browser/app/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,6 @@ if CONFIG['MOZ_LINKER']:
if CONFIG['HAVE_CLOCK_MONOTONIC']:
OS_LIBS += CONFIG['REALTIME_LIBS']

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']

for icon in ('firefox', 'document', 'newwindow', 'newtab', 'pbmode'):
DEFINES[icon.upper() + '_ICO'] = '"%s/dist/branding/%s.ico"' % (
TOPOBJDIR, icon)
3 changes: 0 additions & 3 deletions browser/components/about/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,3 @@ FINAL_LIBRARY = 'browsercomps'
LOCAL_INCLUDES += [
'../build',
]

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions browser/components/build/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,3 @@ if CONFIG['OS_ARCH'] == 'WINNT':
# GTK2: Need to link with glib for GNOME shell service
if CONFIG['MOZ_WIDGET_TOOLKIT'] in ('cocoa', 'gtk2', 'gtk3'):
OS_LIBS += CONFIG['TK_LIBS']

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions browser/components/dirprovider/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,3 @@ FINAL_LIBRARY = 'browsercomps'
LOCAL_INCLUDES += [
'../build'
]

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions browser/components/feeds/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,3 @@ LOCAL_INCLUDES += [

with Files('**'):
BUG_COMPONENT = ('Firefox', 'RSS Discovery and Preview')

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions browser/components/shell/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,3 @@ CXXFLAGS += CONFIG['TK_CFLAGS']

with Files('**'):
BUG_COMPONENT = ('Firefox', 'Shell Integration')

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions devtools/server/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,3 @@ DevToolsModules(
'service-worker-child.js',
'worker.js'
)

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions docshell/base/timeline/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,3 @@ FINAL_LIBRARY = 'xul'
LOCAL_INCLUDES += [
'/docshell/base'
]

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions docshell/build/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,5 @@ include('/ipc/chromium/chromium-config.mozbuild')

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']

if CONFIG['MOZ_DEVTOOLS'] == 'all':
DEFINES['MOZ_DEVTOOLS_ALL'] = True
3 changes: 0 additions & 3 deletions dom/activities/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,3 @@ LOCAL_INCLUDES += [
include('/ipc/chromium/chromium-config.mozbuild')

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/animation/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,3 @@ LOCAL_INCLUDES += [
]

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/archivereader/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ UNIFIED_SOURCES += [
'ArchiveZipFile.cpp',
]

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']

LOCAL_INCLUDES += [
'../base',
]
Expand Down
3 changes: 0 additions & 3 deletions dom/audiochannel/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,3 @@ UNIFIED_SOURCES += [
include('/ipc/chromium/chromium-config.mozbuild')

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/base/test/gtest/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,3 @@ LOCAL_INCLUDES += [
include('/ipc/chromium/chromium-config.mozbuild')

FINAL_LIBRARY = 'xul-gtest'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/battery/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,3 @@ include('/ipc/chromium/chromium-config.mozbuild')
FINAL_LIBRARY = 'xul'

MOCHITEST_MANIFESTS += ['test/mochitest.ini']

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/broadcastchannel/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,3 @@ BROWSER_CHROME_MANIFESTS += ['tests/browser.ini']
include('/ipc/chromium/chromium-config.mozbuild')

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/browser-element/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,3 @@ MOCHITEST_MANIFESTS += [
'mochitest/priority/mochitest.ini',
]
MOCHITEST_CHROME_MANIFESTS += ['mochitest/chrome.ini']

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/canvas/compiledtest/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ GeckoCppUnitTests([
'TestWebGLElementArrayCache',
])

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']

LOCAL_INCLUDES += [
'../',
]
3 changes: 0 additions & 3 deletions dom/cellbroadcast/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,3 @@ IPDL_SOURCES += [
include('/ipc/chromium/chromium-config.mozbuild')

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/devicestorage/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,3 @@ MOCHITEST_MANIFESTS += [
'test/mochitest.ini',
]
MOCHITEST_CHROME_MANIFESTS += ['test/chrome.ini']

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/encoding/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,3 @@ MOCHITEST_MANIFESTS += [
]
MOCHITEST_CHROME_MANIFESTS += ['test/chrome.ini']
XPCSHELL_TESTS_MANIFESTS += ['test/unit/xpcshell.ini']

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/filesystem/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,3 @@ LOCAL_INCLUDES += [
'/dom/base',
'/dom/workers',
]

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/fmradio/ipc/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,3 @@ FINAL_LIBRARY = 'xul'
LOCAL_INCLUDES += [
'/dom/fmradio',
]

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/fmradio/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,3 @@ LOCAL_INCLUDES += [
'../system/gonk',
]
include('/ipc/chromium/chromium-config.mozbuild')

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/gamepad/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,3 @@ CFLAGS += CONFIG['GLIB_CFLAGS']
CFLAGS += CONFIG['MOZ_DBUS_GLIB_CFLAGS']
CXXFLAGS += CONFIG['GLIB_CFLAGS']
CXXFLAGS += CONFIG['MOZ_DBUS_GLIB_CFLAGS']

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/geolocation/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,3 @@ elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'windows':
LOCAL_INCLUDES += [
'/dom/system/windows',
]

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/icc/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,3 @@ FINAL_LIBRARY = 'xul'
LOCAL_INCLUDES += [
'/dom/system/gonk',
]

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/inputport/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,3 @@ XPCSHELL_TESTS_MANIFESTS += ['test/xpcshell/xpcshell.ini']
include('/ipc/chromium/chromium-config.mozbuild')

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/json/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,3 @@ FINAL_LIBRARY = 'xul'

XPCSHELL_TESTS_MANIFESTS += ['test/unit/xpcshell.ini']
MOCHITEST_MANIFESTS += ['test/mochitest.ini']

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/jsurl/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,3 @@ FINAL_LIBRARY = 'xul'
include('/ipc/chromium/chromium-config.mozbuild')

MOCHITEST_MANIFESTS += ['test/mochitest.ini']

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/mathml/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,3 @@ FINAL_LIBRARY = 'xul'
LOCAL_INCLUDES += [
'/dom/base',
]

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/media/android/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,3 @@ LOCAL_INCLUDES += [
]

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/media/gmp-plugin-openh264/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,3 @@ USE_STATIC_LIBS = True
NO_VISIBILITY_FLAGS = True
# Don't use STL wrappers; this isn't Gecko code
DISABLE_STL_WRAPPING = True

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/media/gmp-plugin/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,3 @@ USE_STATIC_LIBS = True
NO_VISIBILITY_FLAGS = True
# Don't use STL wrappers; this isn't Gecko code
DISABLE_STL_WRAPPING = True

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/media/imagecapture/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,3 @@ UNIFIED_SOURCES += [
]

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/messagechannel/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,3 @@ LOCAL_INCLUDES += [
include('/ipc/chromium/chromium-config.mozbuild')

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/nfc/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,3 @@ if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk' and CONFIG['MOZ_NFC']:
include('/ipc/chromium/chromium-config.mozbuild')

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/offline/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,3 @@ LOCAL_INCLUDES += [
]

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/payment/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,3 @@ LOCAL_INCLUDES += [
XPCSHELL_TESTS_MANIFESTS += ['tests/unit/xpcshell.ini']

MOCHITEST_MANIFESTS += ['tests/mochitest/mochitest.ini']

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/permission/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,4 @@ if CONFIG['MOZ_TIME_MANAGER']:

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']

include('/ipc/chromium/chromium-config.mozbuild')
3 changes: 0 additions & 3 deletions dom/plugins/base/android/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,3 @@ LOCAL_INCLUDES += [
DEFINES['MOZ_APP_NAME'] = '"%s"' % CONFIG['MOZ_APP_NAME']

CXXFLAGS += CONFIG['MOZ_CAIRO_CFLAGS']

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/power/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,3 @@ FINAL_LIBRARY = 'xul'

MOCHITEST_MANIFESTS += ['test/mochitest.ini']
BROWSER_CHROME_MANIFESTS += ['test/browser.ini']

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/presentation/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,3 @@ LOCAL_INCLUDES += [
include('/ipc/chromium/chromium-config.mozbuild')

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/presentation/provider/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,3 @@ UNIFIED_SOURCES += [

include('/ipc/chromium/chromium-config.mozbuild')
FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/push/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ TEST_DIRS += ['test/xpcshell']

include('/ipc/chromium/chromium-config.mozbuild')

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']

LOCAL_INCLUDES += [
'../base',
'../ipc',
Expand Down
4 changes: 2 additions & 2 deletions dom/security/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@ LOCAL_INCLUDES += [
]

if CONFIG['GNU_CC']:
CFLAGS += ['-Wshadow', '-Wformat-security']
CXXFLAGS += ['-Wshadow', '-Wformat-security']
CFLAGS += ['-Wformat-security']
CXXFLAGS += ['-Wformat-security']
3 changes: 0 additions & 3 deletions dom/smil/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,3 @@ LOCAL_INCLUDES += [
]

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/speakermanager/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,3 @@ UNIFIED_SOURCES += [
include('/ipc/chromium/chromium-config.mozbuild')

FINAL_LIBRARY = 'xul'

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
3 changes: 0 additions & 3 deletions dom/storage/moz.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,3 @@ LOCAL_INCLUDES += [

if CONFIG['ENABLE_TESTS']:
DEFINES['DOM_STORAGE_TESTS'] = True

if CONFIG['GNU_CXX']:
CXXFLAGS += ['-Wshadow']
Loading

0 comments on commit c15b825

Please sign in to comment.