Bug 1347884 - Enable eslint cyclomatic complexity rule at existing le…

…vels. r=jaws

Enable the rule with the maximums set to avoid current failures, except for test_form_autocomplete which is very
high (82). The levels are set per major area, with existing warnings being changed to errors.

MozReview-Commit-ID: 37M6Ry0Mr1c

browser/components/.eslintrc.js

@@ -0,0 +1,9 @@
+"use strict";
+
+module.exports = {
+  rules: {
+    // XXX Bug 1326071 - This should be reduced down - probably to 20 or to
+    // be removed & synced with the toolkit/.eslintrc.js value.
+    "complexity": ["error", {"max": 69}],
+  }
+};

browser/components/migration/.eslintrc.js

@@ -19,7 +19,7 @@ module.exports = { // eslint-disable-line no-undef
     "comma-dangle": "off",
     "comma-spacing": ["warn", {"before": false, "after": true}],
     "comma-style": ["warn", "last"],
-    // "complexity": "warn",
+    "complexity": ["error", {"max": 21}],
     "consistent-return": "error",
     //"curly": "error",
     "dot-notation": "error",
@@ -79,4 +79,3 @@ module.exports = { // eslint-disable-line no-undef
     "yoda": "error"
   }
 };
-

browser/extensions/formautofill/.eslintrc.js

@@ -109,7 +109,7 @@ module.exports = { // eslint-disable-line no-undef
     "comma-dangle": ["error", "always-multiline"],
 
     // Warn about cyclomatic complexity in functions.
-    "complexity": "warn",
+    "complexity": ["error", {"max": 20}],
 
     // Don't warn for inconsistent naming when capturing this (not so important
     // with auto-binding fat arrow functions).

toolkit/.eslintrc.js

@@ -22,6 +22,10 @@ module.exports = {
     // Commas at the end of the line not the start
     // "comma-style": "error",
 
+    // Warn about cyclomatic complexity in functions.
+    // XXX Bug 1326071 - This should be reduced down - probably to 20.
+    "complexity": ["error", {"max": 48}],
+
     // Don't require spaces around computed properties
     "computed-property-spacing": ["error", "never"],
 
@@ -54,6 +58,10 @@ module.exports = {
     // Unix linebreaks
     "linebreak-style": ["error", "unix"],
 
+    // Don't enforce the maximum depth that blocks can be nested. The complexity
+    // rule is a better rule to check this.
+    "max-depth": "off",
+
     // Always require parenthesis for new calls
     // "new-parens": "error",
 

toolkit/components/narrate/.eslintrc.js

@@ -25,7 +25,7 @@ module.exports = { // eslint-disable-line no-undef
     "comma-dangle": "off",
     "comma-spacing": ["warn", {"before": false, "after": true}],
     "comma-style": ["warn", "last"],
-    "complexity": "warn",
+    "complexity": ["error", {"max": 20}],
     "consistent-return": "error",
     "curly": "error",
     "dot-location": ["warn", "property"],

toolkit/components/satchel/test/test_form_autocomplete.html

@@ -234,7 +234,7 @@
  *     to listen to for when the search is complete.
  *   - some items still use setTimeout
  */
-function runTest() {
+function runTest() { // eslint-disable-line complexity
   testNum++;
 
   ok(true, "Starting test #" + testNum);

toolkit/mozapps/extensions/.eslintrc.js

@@ -2,6 +2,11 @@
 
 module.exports = { // eslint-disable-line no-undef
   "rules": {
+    // Warn about cyclomatic complexity in functions.
+    // XXX Bug 1326071 - This should be reduced down - probably to 20 or to
+    // be removed & synced with the toolkit/.eslintrc.js value.
+    "complexity": ["error", {"max": 60}],
+
     // No using undeclared variables
     "no-undef": "error",