Bug 1328800 - Enable the no-sparse-arrays rule for eslint and change …

…the two instances of it to use 'undefined' instead of a sparse array since the test will still be fine either way. r=mak MozReview-Commit-ID: 5oceKd1EJYR
mozilla-spidermonkey · Jan 5, 2017 · 88b29a7 · 88b29a7
1 parent 5eaacfd
commit 88b29a7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/toolkit/.eslintrc.js b/toolkit/.eslintrc.js
@@ -156,6 +156,9 @@ module.exports = {
     // No declaring variables that hide things like arguments
     "no-shadow-restricted-names": "error",
 
+    // Disallow sparse arrays
+    "no-sparse-arrays": "error",
+
     // No trailing whitespace
     "no-trailing-spaces": "error",
 

diff --git a/toolkit/components/places/tests/unit/test_tagging.js b/toolkit/components/places/tests/unit/test_tagging.js
@@ -119,13 +119,13 @@ function run_test() {
   let curChildCount = tagRoot.childCount;
 
   try {
-    tagssvc.tagURI(uri1, [, "tagSparse"]);
+    tagssvc.tagURI(uri1, [undefined, "tagSparse"]);
     do_check_eq(tagRoot.childCount, curChildCount + 1);
   } catch (ex) {
     do_throw("Passing a sparse array should not throw");
   }
   try {
-    tagssvc.untagURI(uri1, [, "tagSparse"]);
+    tagssvc.untagURI(uri1, [undefined, "tagSparse"]);
     do_check_eq(tagRoot.childCount, curChildCount);
   } catch (ex) {
     do_throw("Passing a sparse array should not throw");