Bug 1547133 - Change .fieldKeys from var to let. r=jorendorff

Also fixes bug 1547136. Differential Revision: https://phabricator.services.mozilla.com/D28928
mozilla-spidermonkey · Apr 30, 2019 · 71e5168 · 71e5168
1 parent 5944f8c
commit 71e5168
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/js/src/frontend/Parser.cpp b/js/src/frontend/Parser.cpp
@@ -7070,7 +7070,7 @@ GeneralParser<ParseHandler, Unit>::classDefinition(
     }
 
     if (numFieldKeys > 0) {
-      if (!noteDeclaredName(cx_->names().dotFieldKeys, DeclarationKind::Var,
+      if (!noteDeclaredName(cx_->names().dotFieldKeys, DeclarationKind::Let,
                             namePos)) {
         return null();
       }

diff --git a/js/src/jit-test/tests/fields/bug1540798.js b/js/src/jit-test/tests/fields/bug1540798.js
@@ -1,3 +1,5 @@
+// |jit-test| --enable-experimental-fields
+
 try { evaluate(`
 class constructor  { get;                                           } // Long line is long
 // Long line XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

diff --git a/js/src/jit-test/tests/fields/bug1547133.js b/js/src/jit-test/tests/fields/bug1547133.js
@@ -0,0 +1,5 @@
+// |jit-test| --enable-experimental-fields
+
+class C47 {
+  static method(s = class { [y75] = 42; }) {}
+}
diff --git a/js/src/jit-test/tests/fields/bug1547136.js b/js/src/jit-test/tests/fields/bug1547136.js
@@ -0,0 +1,3 @@
+// |jit-test| --enable-experimental-fields
+
+try {} catch ([ c = class { ["s"] }]) {}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		// \|jit-test\| --enable-experimental-fields

		try {} catch ([ c = class { ["s"] }]) {}