Bug 1358949 - Lower eslint cyclomatic complexity threshold in some di…

…rectories. r=standard8

We can lower the eslint cyclomatic complexity threshold in some directories without adding eslint suppression comments in any .js source files. We need to specify the complexity rule in accessible/.eslintrc because it doesn't inherit the mozilla/recommended rules. eslint's default complexity threshold is 20.

Also bump the eslint-plugin-mozilla version because we modified the mozilla/recommended rules.

MozReview-Commit-ID: 57T4gAjPH7z

accessible/.eslintrc.js

@@ -15,6 +15,9 @@ module.exports = {
     "XPCOMUtils": true
   },
   "rules": {
+    // Warn about cyclomatic complexity in functions.
+    "complexity": ["error", 42],
+
     // Maximum depth callbacks can be nested.
     "max-nested-callbacks": ["error", 10],
   }

accessible/tests/browser/.eslintrc.js

@@ -62,7 +62,7 @@ module.exports = { // eslint-disable-line no-undef
     "comma-dangle": ["error", "never"],
     "comma-spacing": "error",
     "comma-style": ["error", "last"],
-    "complexity": ["error", 35],
+    "complexity": ["error", 20],
     "consistent-this": "off",
     "curly": ["error", "multi-line"],
     "default-case": "off",

browser/components/.eslintrc.js

@@ -4,6 +4,6 @@ module.exports = {
   rules: {
     // XXX Bug 1326071 - This should be reduced down - probably to 20 or to
     // be removed & synced with the mozilla/recommended value.
-    "complexity": ["error", {"max": 69}],
+    "complexity": ["error", 61],
   }
 };

mobile/android/.eslintrc

@@ -47,6 +47,11 @@ rules:
     camelcase: 0
     comma-dangle: 0
     comma-spacing: 0
+
+    # XXX Bug 1358949 - This should be reduced down - probably to 20 or to
+    # be removed & synced with the mozilla/recommended value.
+    complexity: ["error", 31]
+
     consistent-return: 0
     curly: 0
     dot-notation: 0

mobile/android/chrome/content/.eslintrc

@@ -17,6 +17,8 @@ globals:
     Rect: false
 
 rules:
+    complexity: ["error", 20]
+
     # Disabled stuff
     no-console: 0 # TODO: Can we use console?
     no-cond-assign: 0

toolkit/.eslintrc.js

@@ -8,6 +8,6 @@ module.exports = {
   rules: {
     // XXX Bug 1326071 - This should be reduced down - probably to 20 or to
     // be removed & synced with the mozilla/recommended value.
-    "complexity": ["error", {"max": 48}],
+    "complexity": ["error", 41],
   }
 };

toolkit/components/passwordmgr/.eslintrc.js

@@ -15,6 +15,10 @@ module.exports = {
     // Commas at the end of the line not the start
     "comma-style": "error",
 
+    // XXX Bug 1358949 - This should be reduced down - probably to 20 or to
+    // be removed & synced with the mozilla/recommended value.
+    "complexity": ["error", 43],
+
     // Use [] instead of Array()
     "no-array-constructor": "error",
 

toolkit/content/.eslintrc.js

@@ -8,4 +8,10 @@ module.exports = {
   "plugins": [
     "mozilla"
   ],
+
+  rules: {
+    // XXX Bug 1358949 - This should be reduced down - probably to 20 or to
+    // be removed & synced with the mozilla/recommended value.
+    "complexity": ["error", 48],
+  }
 };

tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js

@@ -45,7 +45,7 @@ module.exports = {
 
     // Warn about cyclomatic complexity in functions.
     // XXX Get this down to 20?
-    "complexity": ["error", {"max": 35}],
+    "complexity": ["error", 32],
 
     // Don't require spaces around computed properties
     "computed-property-spacing": ["error", "never"],

tools/lint/eslint/eslint-plugin-mozilla/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-mozilla",
-  "version": "0.2.43",
+  "version": "0.2.44",
   "description": "A collection of rules that help enforce JavaScript coding standard in the Mozilla project.",
   "keywords": [
     "eslint",