Bug 1407137 - Implement Swap(Atomic<T, Order>&, Atomic<T, Order>&) = …

…delete; to remove an actually-non-atomic footgun. r=froydnj
mozilla-spidermonkey · Oct 10, 2017 · 06a00d3 · 06a00d3
1 parent 6cd32e0
commit 06a00d3
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/mfbt/Atomics.h b/mfbt/Atomics.h
@@ -558,6 +558,11 @@ class Atomic<bool, Order>
   Atomic(Atomic<bool, Order>& aOther) = delete;
 };
 
+// If you want to atomically swap two atomic values, use exchange().
+template<typename T, MemoryOrdering Order>
+void
+Swap(Atomic<T, Order>&, Atomic<T, Order>&) = delete;
+
 } // namespace mozilla
 
 #endif /* mozilla_Atomics_h */