Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: handle duplicate keys in batch_upload_items for mysql #873

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Conversation

jrconlin
Copy link
Member

Closes #827

Description

Handle duplicate keys while appending items into batch_upload_items

Testing

Test included.

Issue(s)

Closes #827

@jrconlin jrconlin requested a review from a team October 23, 2020 16:06
fzzzy
fzzzy previously approved these changes Oct 23, 2020
Copy link
Contributor

@fzzzy fzzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simpler implementation, too. Great. Just one nit.

src/db/mysql/batch.rs Outdated Show resolved Hide resolved
@jrconlin jrconlin requested review from a team and fzzzy October 23, 2020 19:59
src/db/mysql/batch.rs Show resolved Hide resolved
src/db/mysql/batch.rs Outdated Show resolved Hide resolved
applied to the right branch this time. 🤦
@jrconlin jrconlin requested review from pjenvey and a team October 27, 2020 23:36
@jrconlin jrconlin merged commit 2d6039f into master Oct 29, 2020
@jrconlin jrconlin deleted the bug/827 branch October 29, 2020 19:28
@jrconlin jrconlin mentioned this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mysql] Handle AlreadyExists in batch_bsos errors
3 participants