fix: lower max_total_records per batch_commit_update costs #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove the potential, redundant touch_collection on batch commit recalculating the mutations (see adca8d6): - 4 for touch_collection: always an UPDATE on batch commit (due to pretouch_collection). we thought this cost 1 but it's probably 4 (see #333) - 19992 (1666 max_total_records * 12, for the UPDATE case, see #333) for the mix of post_bsos and batch_commit - 2 for batch delete (1 for the delete and 1 BsoExpiry update) total: 19998 Closes #333
jrconlin
approved these changes
Dec 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and remove the potential, redundant touch_collection on batch commit
recalculating the mutations (see adca8d6):
pretouch_collection). we thought this cost 1 but it's probably 4 (see
Seeing spanner 20k mutation limit errors for inserts in production #333)
the mix of post_bsos and batch_commit
total: 19998
Closes #333