Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add spanner tools #292

Merged
merged 6 commits into from
Oct 21, 2019
Merged

feat: add spanner tools #292

merged 6 commits into from
Oct 21, 2019

Conversation

jrconlin
Copy link
Member

@jrconlin jrconlin commented Oct 18, 2019 •
edited
Loading

Add a set of python based tools for managing data in the spanner
database.

Issue: #119, #284

Please remember to consult our contributing guidelines before opening your PR.

  • Title begins with type (fix, feature, doc, chore, etc) and a short description with no period
  • Description outlines the change
  • Test cases included in the change (if appropriate)
  • Closes or Issue link to associated issue(s)

@jrconlin
feat: add spanner tools
21fbdb4 
Add a set of python based tools for managing data in the spanner
database.

Issue: #119, #284
@jrconlin jrconlin requested a review from a team October 18, 2019 15:34
pjenvey
pjenvey requested changes Oct 18, 2019
View reviewed changes
tools/spanner/purge_ttl.py Outdated Show resolved Hide resolved
tools/spanner/purge_ttl.py Outdated Show resolved Hide resolved
jrconlin and others added 3 commits October 18, 2019 13:39
@jrconlin @pjenvey
Update tools/spanner/purge_ttl.py
19e8c16 
Co-Authored-By: Philip Jenvey <pjenvey@underboss.org>
@jrconlin
f r's
30a77a9 
* make purge_ttl a real script
* pull data from env
* add `batches` purge
* delete to expiry
@jrconlin
Merge branch 'tools' of github.com:mozilla-services/syncstorage-rs in…
ff8b38d 
…to tools
@jrconlin
Copy link
Member Author

ok, tweaked up the tools a bit on the last commit.

Made the purge tool a bit more "real". Should still work if someone wanted to use it as a cloud function too.

@jrconlin jrconlin requested a review from pjenvey October 18, 2019 22:15
@pjenvey pjenvey merged commit b9cd9ff into master Oct 21, 2019
@pjenvey pjenvey deleted the tools branch October 21, 2019 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjenvey pjenvey pjenvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrconlin @pjenvey