feat: postgres docker and gar #1945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taddes
force-pushed
the
feat/postgres-docker-STOR-366
branch
from
93087dd to
a615ae4
Compare
chenba
reviewed
Dec 18, 2025
.circleci/config.yml
Outdated
| only: /.*/ | ||
| branches: | ||
| only: master | ||
| # touch: 1676417203 |
Collaborator
There was a problem hiding this comment.
I don't think we need this.
Collaborator
Author
There was a problem hiding this comment.
Yeah, I've wondered what that is... I'll take it out. Wondered if it had some historical significance. Looked at the git blame but didn't offer much and was 2 years ago. Probably useless at this point
chenba
reviewed
Dec 18, 2025
| echo ${DOCKERHUB_REPO}:${DOCKER_TAG}-postgres | ||
| docker tag app:build ${DOCKERHUB_REPO}:${DOCKER_TAG}-postgres | ||
| docker images | ||
| docker push "${DOCKERHUB_REPO}:${DOCKER_TAG}-postgres" |
Collaborator
There was a problem hiding this comment.
Maybe add the postfix to the Spanner image for clarity and consistency?
Collaborator
Author
|
I had @jbuck take a peek at this fyi, he thinks it looks ok but I guess we'll know best once merging to master 🤞 |
chenba
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addition of deploy jobs for Postgres enabled synsctorage-rs. Induces:
-postgressuffix added to end of tag.Issue(s)
Closes STOR-366.