Skip to content

[spanner] Use explicit transactions in db-tests #581

Open
@pjenvey

Description

We still have duplicate sync versions of the SpannerDb::commit/rollback/get_transaction methods methods vs their _async (e.g. commit_async) counterparts. This seems due to the sql_request request method's usage, which can implicitly begin a transaction, yet would be inconvenient if every invocation required an .await.

The implicit beginning of a transaction is only used by db-tests (delete_all also uses it! #615), so we should be able to solve this in a different way (maybe the db::tests::support::db function could call begin for the tests? at least under Spanner)

Metadata

Assignees

No one assigned

    Labels

    3Estimate - m - This is a small change, but there's some uncertainty.cleanup

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions