bug-1892787: handle case where Bugzilla returns bad payload #6785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes Bugzilla returns an HTTP 200 with JSON content, but it doesn't have "bugs" in it. Rather than throw an HTTP 500 because of an unhandled KeyError, this changes the code to raise a BugzillaRestHTTPUnexpectedError with the payload it did get. This will give us a better idea of what's happening so we can figure out what to do about it if anything.
relud
approved these changes
Nov 2, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes Bugzilla returns an HTTP 200 with JSON content, but it doesn't have "bugs" in it.
Rather than throw an HTTP 500 because of an unhandled
KeyError, this changes the code to raise aBugzillaRestHTTPUnexpectedErrorwith the payload it did get. This will give us a better idea of what's happening so we can figure out what to do about it if anything.