Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcs-cli and pubsub-cli script definitions #26

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

relud
Copy link
Member

@relud relud commented Oct 31, 2024

without this the scripts installed (gcs-cli and pubsub-cli) cannot detect any arguments passed

@relud relud requested a review from a team as a code owner October 31, 2024 16:01
Copy link

@biancadanforth biancadanforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does now correctly pass arguments in, so R+ for that.

The gcs-cli throws an error downstream when I pass a subcommand with an argument[1]. Is this still a WIP?

In general, what's the benefit of having a separate GCS/PubSub service in obs-common? IIUC, the idea is we want a central place for these scripts which we use for e.g. socorro's GCS and PubSub services in that project's docker-compose.yml, right?

[1]: google.auth.exceptions.InvalidOperation: Anonymous credentials cannot be refreshed.

@relud
Copy link
Member Author

relud commented Nov 1, 2024

The gcs-cli throws an error downstream when I pass a subcommand with an argument[1]. Is this still a WIP?

you have to set something like STORAGE_EMULATOR_HOST=http://localhost:8001 so that gcs-cli can find the gcs emulator. I'll file a follow-up issue to improve this error message. edit: filed #29

In general, what's the benefit of having a separate GCS/PubSub service in obs-common? IIUC, the idea is we want a central place for these scripts which we use for e.g. socorro's GCS and PubSub services in that project's docker-compose.yml, right?

The benefit of gcs-cli and pubsub-cli being here is that we can re-use the scripts in antenna, socorro, eliot, tecken, etc. Yes, these scripts are for interacting with emulators in the local dev environment. This is in part because the gcloud cli doesn't support interacting with emulators.

@relud relud added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 76f3ab2 Nov 1, 2024
3 checks passed
@relud relud deleted the relud-fix-gcs-pubsub-commands branch November 1, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants