Skip to content

Bug 1684971 - Add previous notification action to default browser agent telemetry #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 25, 2021
Merged

Bug 1684971 - Add previous notification action to default browser agent telemetry #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b180621
Bug 1621703 - Add default browser notification telemetry
bytesized May 14, 2020
7602fe3
Merge remote-tracking branch 'upstream/master'
bytesized Jun 4, 2020
1bf067e
Bug 1621703 - Remove default browser agent's client id
bytesized Jun 4, 2020
4b72d6c
Bug 1621703 - Deprecate default browser agent's client id
bytesized Jun 4, 2020
14e60c8
Merge remote-tracking branch 'upstream/master'
bytesized Jan 25, 2021
d5afc05
Bug 1684971 - Add previous notification action field
bytesized Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions schemas/default-browser-agent/default-browser/default-browser.1.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@
"previous_default_browser": {
"description": "What the default browser was before it was changed to the current one",
"type": "string"
},
"previous_notification_action": {
"description": "What action was taken by the user the last time a toast notification was displayed",
"type": "string"
}
},
"required": [
Expand Down
4 changes: 4 additions & 0 deletions templates/default-browser-agent/default-browser/default-browser.1.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@
"previous_default_browser": {
"description": "What the default browser was before it was changed to the current one",
"type": "string"
},
"previous_notification_action": {
"description": "What action was taken by the user the last time a toast notification was displayed",
"type": "string"
}
},
"required": [
Expand Down
12 changes: 12 additions & 0 deletions ...on/default-browser-agent/default-browser.1.sample_with_prev_notification_action.pass.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"build_channel": "nightly",
"build_version": "74.0a1",
"os_version": "10.0.18363.592",
"os_locale": "en-US",
"default_browser": "firefox",
"previous_default_browser": "edge",
"notification_type": "initial",
"notification_shown": "shown",
"notification_action": "dismissed-by-timeout",
"previous_notification_action": "no-action"
}