Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make geoname IDs ints #670

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

0c0w3
Copy link
Collaborator

@0c0w3 0c0w3 commented Oct 18, 2024

Description

The suggest client expects geoname IDs to be ints, not strings. They are in fact ints in the GeoNames dataset.

PR Review Checklist

Put an x in the boxes that apply

  • This PR conforms to the Contribution Guidelines
  • The PR title starts with the JIRA issue reference, format [DISCO-####], and has the same title (if applicable)
  • [load test: (abort|warn)] keywords are applied (if applicable)
  • Documentation has been updated (if applicable)
  • Functional and performance test coverage has been expanded and maintained (if applicable)

The suggest client expects geoname IDs to be ints, not strings. They are in fact
ints in the GeoNames dataset.
@0c0w3 0c0w3 requested a review from ncloudioj October 18, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant