Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

test: add contract tests for tiles caching #431

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Conversation

Trinaa
Copy link
Collaborator

@Trinaa Trinaa commented Aug 1, 2022

Description

  • Update docker-compose.yml:
    • Set the contile CONTILE_TILES_TTL environment variable to 0, preventing interactions between scenario executions due to tiles caching.
  • Update scenarios.yml:
    • Add success_tiles_cache_expired in order to test that Contile requests tiles from the partner, when its cached tiles are expired.
  • Create scenarios_tiles_cache.yml:
    • Add success_tiles_cache_with_same_form_and_region in order to test that Contile will use tiles from its cache, instead of from the partner, for requests that map to the same form-factor and region.
    • Add success_tiles_cache_with_different_form_and_region in order to test that Contile will use tiles from the partner, instead of from its cache, for requests that map to different form-factors and regions.
  • Create docker-compose.tiles_cache.yml:
    • Set the contile CONTILE_TILES_TTL environment variable to 900 (15 minutes is the production default)
    • Set the client SCENARIOS_FILE environment variable to scenarios_tiles_cache.yml
  • Update the CircleCI config to include the tiles cache tests
  • Update the contract-tests README sequence diagram

Issue(s)

CONSVC-1232

@Trinaa Trinaa force-pushed the contract-tests-cache branch 6 times, most recently from 31c5500 to d95d83b Compare August 3, 2022 20:12
@Trinaa Trinaa marked this pull request as ready for review August 3, 2022 20:31
@Trinaa Trinaa requested a review from a team as a code owner August 3, 2022 20:31
@Trinaa Trinaa force-pushed the contract-tests-cache branch from d95d83b to 010c5f4 Compare August 3, 2022 21:06
jrconlin
jrconlin previously approved these changes Aug 4, 2022
pjenvey
pjenvey previously approved these changes Aug 9, 2022
Copy link
Member

@hackebrot hackebrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Trinaa! 👋🏻

This is almost ready to be merged! There's one issue with the sequence diagram. I added my comment inline.

@Trinaa Trinaa dismissed stale reviews from pjenvey and jrconlin via 012ef0d August 10, 2022 15:27
Copy link
Member

@hackebrot hackebrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Trinaa Trinaa merged commit 8e43e07 into main Aug 10, 2022
@Trinaa Trinaa deleted the contract-tests-cache branch August 10, 2022 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants