This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
Feat/201 jitter #221
Merged
Feat/201 jitter #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
approved these changes
Jul 27, 2021
| let mut rng = thread_rng(); | ||
| let ftl = settings.tiles_ttl as f32; | ||
| let offset = ftl * (std::cmp::min(settings.jitter, 50) as f32 * 0.01); | ||
| let jit = rng.gen_range(0.0 - offset..offset); |
There was a problem hiding this comment.
Shouldn't it be inclusive (I don't actually care 😄 )?
Suggested change
| let jit = rng.gen_range(0.0 - offset..offset); | |
| let jit = rng.gen_range(0.0 - offset..=offset); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a setting to add "jitter" to a given tiles in memory cache TTL
Testing
Set the
CONTILE_JITTER=0and note that tiles do not display jitter and expire exactly atCONTILE_TTL.Set the
CONTILE_JITTER=50and note that tiles expire at any time between 50 and 150% ofCONTILE_TTL.Issue(s)
Closes #201