Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

chore: update dependencies to address audit issue #12

Merged
merged 13 commits into from
Feb 16, 2021
Merged

Conversation

jrconlin
Copy link
Member

@jrconlin jrconlin commented Feb 9, 2021

Description

Quick update to match skeleton update and address cargo audit issue.

Testing

N/A

#Issue

Closes #15

@jrconlin jrconlin requested a review from a team February 9, 2021 00:55
@pjenvey
Copy link
Member

pjenvey commented Feb 9, 2021

@jrconlin My #9 PR has fixes for circleci/docker builds, wanna get that merged first and rebase on top of it?

@@ -127,14 +127,14 @@ jobs:
#- save-sccache-cache
- run:
name: Build Docker image
command: docker build -t app:build .
command: docker build -t fx-tiles:build .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The app name's just a temporary for saving the docker artifact in between the circleci workflow. When it's ultimately pushed to docker hub it gets the right name from ${DOCKERHUB_REPO}.

I'd lean towards keeping the app name just to match the original 2 skeletons this is derived from (dockerflow + our rust skeleton) -- in case we need to update it from the skeleton, one less delta to deal with

@jrconlin
Copy link
Member Author

jrconlin commented Feb 11, 2021 via email

@jrconlin jrconlin merged commit 04d7e5c into main Feb 16, 2021
@jrconlin jrconlin deleted the chore/update-202102 branch February 23, 2021 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies and address RUSTSEC issues.
2 participants