This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
chore: update dependencies to address audit issue #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add UA parsing back, since test looks for it.
several packages blocking on actix-web 4?
pjenvey
approved these changes
Feb 10, 2021
.circleci/config.yml
Outdated
@@ -127,14 +127,14 @@ jobs: | |||
#- save-sccache-cache | |||
- run: | |||
name: Build Docker image | |||
command: docker build -t app:build . | |||
command: docker build -t fx-tiles:build . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: The app
name's just a temporary for saving the docker artifact in between the circleci workflow. When it's ultimately pushed to docker hub it gets the right name from ${DOCKERHUB_REPO}
.
I'd lean towards keeping the app
name just to match the original 2 skeletons this is derived from (dockerflow + our rust skeleton) -- in case we need to update it from the skeleton, one less delta to deal with
Yeah, wasn't quite sure about that. I was getting some local issues
building things with the circleci CLI, but I can address that.
…On Wed, Feb 10, 2021 at 12:17 PM Philip Jenvey ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In .circleci/config.yml
<#12 (comment)>
:
> @@ -127,14 +127,14 @@ jobs:
#- save-sccache-cache
- run:
name: Build Docker image
- command: docker build -t app:build .
+ command: docker build -t fx-tiles:build .
nit: The app name's just a temporary for saving the docker artifact in
between the circleci workflow. When it's ultimately pushed to docker hub it
gets the right name from ${DOCKERHUB_REPO}.
I'd lean towards keeping the app name just to match the original 2
skeletons this is derived from (dockerflow + our rust skeleton) -- in case
we need to update it from the skeleton, one less delta to deal with
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAIXKZ462NVZTVQ2LN64VTS6LSVPANCNFSM4XKAZXBA>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick update to match skeleton update and address cargo audit issue.
Testing
N/A
#Issue
Closes #15