Bug 1933266 - Add support for mirror URLs for GMP plugins. #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See https://bugzilla.mozilla.org/show_bug.cgi?id=1932482 for the Gecko piece. |
aosmond
force-pushed
the
ao_gmp_mirror_urls
branch
from
94005d5 to
8e0dafb
Compare
|
Sorry, I repushed to add another test because I realized I was missing one for the mirror XML (not just the mirror JSON). |
bhearsum
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
This looks fine to me; there's a few minor comments below.
I also tested this in a local env with this in a widevine release blob:
"WINNT_x86_64-msvc": {
"fileUrl": "https://redirector.gvt1.com/edgedl/widevine-cdm/4.10.1582.2-win-x64.zip",
"filesize": 5097580,
"hashValue": "8054294ad328f0b32e7474448e77fb4c56dbe4e7100920461508dd18cab94f69b13dbc1e9776800f49993d478827b4a65732a9bc39a3940251d9cb96ffffddd9",
"mirrorUrls": [
"https://redirector.gvt1.com/edgedl/widevine-cdm/4.10.1582.2-win-x64.zip.bhearsum1",
"https://redirector.gvt1.com/edgedl/widevine-cdm/4.10.1582.2-win-x64.zip.bhearsum2"
]
},
I ended up with what appears to be expected:
<?xml version="1.0"?>
<updates>
<addons>
<addon id="gmp-widevinecdm" URL="https://redirector.gvt1.com/edgedl/widevine-cdm/4.10.1582.2-win-x64.zip" hashFunction="sha512" hashValue="8054294ad328f0b32e7474448e77fb4c56dbe4e7100920461508dd18cab94f69b13dbc1e9776800f49993d478827b4a65732a9bc39a3940251d9cb96ffffddd9" size="5097580" version="4.10.1582.2">
<mirror URL="https://redirector.gvt1.com/edgedl/widevine-cdm/4.10.1582.2-win-x64.zip.bhearsum1"/>
<mirror URL="https://redirector.gvt1.com/edgedl/widevine-cdm/4.10.1582.2-win-x64.zip.bhearsum2"/>
</addon>
</addons>
</updates>
bhearsum
requested changes
Nov 26, 2024
This patch adds support for alternative URLs from which the GMP plugin can be downloaded. This is useful for GMP plugins, particularly Widevine, because there are many different mirrors from Google. Some users have trouble accessing the preferred mirror due to networking issues, so it would be ideal to supply alternative domains that are more likely to resolve/be reachable as a backup.
aosmond
force-pushed
the
ao_gmp_mirror_urls
branch
from
8e0dafb to
5b7a4c1
Compare
aosmond
changed the title
jcristau
approved these changes
Nov 27, 2024
bhearsum
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for alternative URLs from which the GMP plugin can be downloaded. This is useful for GMP plugins, particularly Widevine, because there are many different mirrors from Google. Some users have trouble accessing the preferred mirror due to networking issues, so it would be ideal to supply alternative domains that are more likely to resolve/be reachable as a backup.