This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Add unit tests for sanitizing custom domains #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sdaswani not an urgent PR but following up on the unit tests requested. |
Sdaswani
approved these changes
Dec 7, 2017
Sdaswani
reviewed
Dec 7, 2017
|
@Sdaswani thanks for approving. I ran the tests locally, going forward should I post a screenshot of those tests passing? |
|
Sure, thanks @joeyg . |
|
@joeyg we're going to turn on BB for PR's from forks so you won't have to do that going forward :) |
|
Ah great thanks! |
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 14, 2024
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #764.