This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Add Print and Save as PDF to Share Sheet #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boek
approved these changes
Sep 27, 2017
|
Thanks for the PR @joeyg! Will test this on my device tonight. Gotta find someone with an AirPrint printer 😁. |
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 14, 2024
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #491. Note that it does not include the header & footer information: URL, page title, date, page number like the Firefox iOS app does. I am happy to add those but it would make the pull request a bit larger. Page title isn't available at the moment but should be after the move to WKWebView.
Screencast: http://recordit.co/yzdRENdssk