Xcode 9 upgrade #478
Xcode 9 upgrade #478
Conversation
|
Hey @joeyg, thanks again for all the activity! Did you have the latest changes from master? I Think these changes have already landed (https://github.com/mozilla-mobile/focus-ios/blob/master/Cartfile) |
|
@boek Yeah i pulled down the latest from master and was having trouble building after clearing out my Carthage directory and Carthage cache. I am not sure if it matters but it looks like the only difference between the SnapKit "swift-4" branch and what is the in "4.0.0" release is that the |
|
Interesting. What version of Xcode are you using? I'm on |
|
Definitely want to lock on the release branch though! |
|
@boek I am also using |
| @@ -55,7 +55,7 @@ private class BlockerEnabledDetector9: BlockerEnabledDetector, SFSafariViewContr | |||
| enabled = true | |||
| self.callback = callback | |||
|
|
|||
| let detectURL = URL(string: "http://localhost:\(server.port)/enabled-detector")! | |||
| let detectURL = URL(string: "http://localhost:\(server?.port)/enabled-detector")! | |||
There was a problem hiding this comment.
I think this will print http://localhost:Optional(<port number>)/enabled-detector. We could either unwrap or map it.
|
@joeyg really interesting. Curious what else could be different about our environments. |
|
Ahh I'll take care of the bug in a bit. Regarding my environment here is what I am seeing (but maybe it is just me): After I do: $ rm -rf Carthage ~/Library/Caches/org.carthage.CarthageKit
$ xcodebuild -version
Xcode 9.0
Build version 9A235
$ carthage bootstrap
...
Checking out SnapKit at "d31148f449abe819fd1a58d5e07e94874c7e6003"
...
Building scheme "SnapKit" in SnapKit.xcworkspace
Build Failed
Task failed with exit code 65:
/usr/bin/xcrun xcodebuild -workspace focus-ios/Carthage/Checkouts/SnapKit/SnapKit.xcworkspace -scheme SnapKit -configuration Release -derivedDataPath Library/Caches/org.carthage.CarthageKit/DerivedData/9.0_9A235/SnapKit/d31148f449abe819fd1a58d5e07e94874c7e6003 ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES build (launched in /focus-ios/Carthage/Checkouts/SnapKit)
I start getting errors like this when compiling the SnapKit dependency: focus-ios/Carthage/Checkouts/SnapKit/Source/ConstraintInsets.swift:34:41: error: 'EdgeInsets' has been renamed to 'NSEdgeInsets'
public typealias ConstraintInsets = EdgeInsets
^~~~~~~~~~
NSEdgeInsets
Foundation.EdgeInsets:2:18: note: 'EdgeInsets' was obsoleted in Swift 4So then I updated SnapKit in the Cartfile to 4.0.0 and tried again and didn't receive the build errors. |
|
@joeyg Just curious, if you delete your derived data will master build for you? Also, this shouldn't be a factor. But do you get the same output if you run |
|
@boek ugh yes using |
|
good to hear! These are good changes regardless :) |
|
Thanks for all your help @boek glad I could help out. |
* Xcode 9 upgrade * Xcode 9: unwrap server for building server url string
* Xcode 9 upgrade * Xcode 9: unwrap server for building server url string
I downloaded Xcode 9 from Apple Developer site today and ran into a few issues. These changes let me compile and run the app.
Firefox iOS has been Xcode 9 on master for a bit now so as a developer it would be helpful if both projects used the same Xcode version.