Track search hint usage

[joeyg]

Send Telemetry event with the method "select_query"

[Sdaswani]

This seems to be changing telemetry, and not adding any?

[Sdaswani]

Thanks again for your contribution!

[joeyg]

@Sdaswani - I modified the event that is being fired off when a user taps on the search hint. Maybe I misunderstood the requirements.

[Sdaswani]

No worries @joeyg - so looking at #381, @bbinto wants to add another telemetry event. If you are typing something you can either press return to go to that page OR you can press the 'Search for' option below the URL bar. We want to add telemetry there. Let me know if that makes sense or not. cc @boek

[joeyg]

@Sdaswani - ok. Next week I can take a look to make sure we are sending an event when the user hits enter as well. What the PR currently does is send an event when the user presses a Search For option. You are correct that I changed the event, I believe it was sending the wrong one.

[Sdaswani]

@joeyg I think this is a no-op actually - I think #381 is already done, i.e., if @bbinto looks at the data, 'type_query' should be showing up in the data. @bbinto please take a look and let us know - for some reason I can't see it in the data.

[Sdaswani]

Actually on second thought maybe it's not already done - @boek perhaps we are using 'typeQuery' for both interactions?

[boek]

Hey @joeyg, thanks again for the contribution! I'll be taking a look at this today to see if we can get this cleared up :)

[joeyg]

@boek thanks for taking a look.

[boek]

@Sdaswani Correct, we were using the same event in both locations. Lets get this change in 👍