Skip to content

Bugfix FXIOS-15549 Minimal address bar should expand before reaching pull to refresh#34601

Open
yoanarios wants to merge 1 commit into
mainfrom
yrd/no-scrollable-content-fix
Open

Bugfix FXIOS-15549 Minimal address bar should expand before reaching pull to refresh#34601
yoanarios wants to merge 1 commit into
mainfrom
yrd/no-scrollable-content-fix

Conversation

@yoanarios

Copy link
Copy Markdown
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Show toolbar if the content becomes not scrollable example a popup appears and the toolbar is collapsed, force showToolbars so the user can reload or interact with the urlbar

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@yoanarios yoanarios requested a review from thatswinnie July 9, 2026 18:28
@yoanarios yoanarios requested a review from a team as a code owner July 9, 2026 18:28
@mobiletest-ci-bot

Copy link
Copy Markdown
Messages
📖 Project coverage: 44.63%

💪 Quality guardian

1 tests files modified. You're a champion of test coverage! 🚀

🧹 Tidy commit

Just 2 file(s) touched. Thanks for keeping it clean and review-friendly!

✅ Code coverage

  • No new files detected so the coverage gate wasn't run.
  • No modified files had significant enough changes for the coverage gate to run.

Client.app: Coverage: 43.53

File Coverage
LegacyTabScrollController.swift 66.46%

Generated by 🚫 Danger Swift against 81bd6a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants