Feature FXIOS-16158 [Toolbar] Add an interactive swipe gesture to close a tab and open the tab tray by Alex-Bangu · Pull Request #34539 · mozilla-mobile/firefox-ios

Alex-Bangu · 2026-07-06T16:03:34Z

📜 Tickets

💡 Description

Implements a significantly more involved swipe up / pan up gesture. Users will be able to drag up on the address bar to open the tab tray. They will also be able to close the tab if they drag the tab into the top 1/4 of their screen, however this is gated behind a separate feature flag.

Major changes:

Two new files that implement a pan gesture handler for the new gesture, SwipeUpTabWebViewPreview.swift and SwipeUpTabPreviewGestureHandler.swift
Refactor of the open tab tray animation in TabAnimation.swift

Other changes:

Minimal changes to several other files
Added a new feature flag switch and did some changes to how we use the existing address bar gesture feature flags

🎥 Demos

Before	After
https://github.com/user-attachments/assets/f8d2a79d-9ad3-49b4-a43a-fe811f3eda62	https://github.com/user-attachments/assets/3e14e4c7-a72b-4660-91cd-1ac9e96e7bc0

📝 Checklist

I filled in the ticket numbers and a description of my work
I updated the PR name to follow our PR naming guidelines
I ensured unit tests pass and wrote tests for new code
If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
If adding telemetry, I read the data stewardship requirements and will request a data review
If adding or modifying strings, I read the guidelines and will request a string review from l10n
If needed, I updated documentation and added comments to complex code

mergify · 2026-07-06T16:11:18Z

This pull request has conflicts when rebasing. Could you fix it @Alex-Bangu? 🙏

mobiletest-ci-bot · 2026-07-06T16:59:26Z

Fails

🚫

❌ Code coverage

The following file(s) are below their scaled coverage:

File	Coverage	Required
`firefox-ios/Client/Frontend/Browser/Toolbars/SwipeUpTabPreviewGestureHandler.swift`	33.3%	62.1%
`firefox-ios/Client/TabManagement/SwipeUpTabWebViewPreview.swift`	35.7%	63.6%
`firefox-ios/Client/Frontend/Browser/Tabs/Views/Animation/TabAnimation.swift`	0.0%	24.8%

You can add the ignore-code-coverage label with a short justification to bypass this check. Please also tag a member of the @fxios-unit-test-owners if the bypass is used.

	Messages
📖	Project coverage: 44.65%

🧩 Neat Piece

This PR changes 626 lines. It's a substantial update,
but still review-friendly if there’s a clear description. Thanks for keeping things moving! 🚀

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

🦊 BrowserViewController Check

We’re tracking the size of BrowserViewController.swift to keep it healthy.

✨ Change in file size: +24 lines

Client.app: Coverage: 43.51

File	Coverage
FeatureFlagsDebugViewController.swift	0.0%	⚠️
SwipeUpTabWebViewPreview.swift	35.68%	⚠️
GeneralBrowserAction.swift	100.0%	✅
TabAnimation.swift	0.0%	⚠️
FeatureFlagID.swift	100.0%	✅
BrowserViewController.swift	38.42%	⚠️
TabDisplayView.swift	34.58%	⚠️
BrowserViewControllerState.swift	53.54%	✅
SwipeUpTabPreviewGestureHandler.swift	33.33%	⚠️
ExperimentTabCell.swift	0.0%	⚠️
AddressBarPanGestureHandler.swift	29.55%	⚠️
NimbusFeatureFlagLayer.swift	84.25%	✅

Generated by 🚫 Danger Swift against 39852d9

PARAIPAN9 · 2026-07-07T09:34:47Z

@Alex-Bangu, just took a glance at the video!! Great work, it looks awesome!!

FilippoZazzeroni · 2026-07-07T15:27:28Z

    var theme: Theme?
+
+    /// UUID of the tab currently minimizing into the tray during the open animation
+    var minimizingTabUUID: TabUUID?


nit: handle this on TabAnimation.swift

FilippoZazzeroni · 2026-07-07T15:27:36Z


                    let a11yId = "\(AccessibilityIdentifiers.TabTray.tabCell)_\(indexPath.section)_\(indexPath.row)"
                    cell.configure(with: tab, theme: theme, delegate: self, a11yId: a11yId, newTabTitle: newTabTitle)
+                    if tab.tabUUID == self.minimizingTabUUID {


same for this

FilippoZazzeroni · 2026-07-07T15:29:55Z

        // safely re-enable the gesture
        if state.addressToolbar.isEditing {
            disablePanGestureRecognizer()
            disableSwipeUpGestureRecognizer()


this can be one method for both up and down, to check also the feature flag inside

FilippoZazzeroni · 2026-07-07T15:30:27Z

        addressToolbarContainer.addGestureRecognizer(panGesture)
        panGestureRecognizer = panGesture

        let swipeUpGesture = UISwipeGestureRecognizer(target: self, action: #selector(handleSwipe))


Add FF check also here

FilippoZazzeroni · 2026-07-07T15:30:56Z

-        let bvcSnapshot = UIImageView(image: browserVC.view.screenshot(quality: UX.bvcScreenshotQuality))
+        // Keep the selected tab cell hidden for the whole animation so it minimizes into an empty
+        // grid square
+        let tabDisplayView = panelViewController.tabDisplayView


this new code path should be under the feature flag

FilippoZazzeroni · 2026-07-07T15:35:07Z

    var microsurveyState: MicrosurveyPromptState
    var autoTranslatePromptState: AutoTranslatePromptState
    var navigationDestination: NavigationDestination?
+    var cellBounds: CGRect?


nit: could we have this property more self explenatory

FilippoZazzeroni · 2026-07-07T15:38:01Z

+    }
+
+    /// The action to take when the gesture ends, based on where the finger is released on screen.
+    enum ReleaseOutcome {


nit: could be on top of the class

FilippoZazzeroni · 2026-07-07T15:39:41Z

+
+    // MARK: - UIGestureRecognizerDelegate
+
+    func gestureRecognizerShouldBegin(_ gestureRecognizer: UIGestureRecognizer) -> Bool {


could be in the AddressBarPanGestureHandler

FilippoZazzeroni · 2026-07-07T15:40:07Z

+        case .ended:
+            let fingerLocation = gesture.location(in: tabPreview)
+            switch tabPreview.releaseOutcome(fingerLocation: fingerLocation) {
+            case .closeTab:


this switch could on a separate method

FilippoZazzeroni · 2026-07-07T15:43:24Z

+import Redux
+
+@MainActor
+class SwipeUpTabPreviewGestureHandler: NSObject, UIGestureRecognizerDelegate, StoreSubscriber, FeatureFlaggable {


port the swipe up and down gesture inside here

Merging main

OrlaM

This PR is too large. I can suggest a way to break it down into 4 PR's but feel free to tackle it a different way if you prefer.
1 PR for each:
Adding and configuring the feature flag.
SwipeUpTabWebViewPreview.swift
SwipeUpTabPreviewGestureHandler.swift
Refactor of the open tab tray animation in TabAnimation.swift

Small PR's are a little more work on the authors side but it makes a big difference in the PR review and code quality side of things.

Alex-Bangu · 2026-07-10T16:51:11Z

Hi Orla!

I'm currently working on breaking up this pr into three parts (new files, animation work, feature flag work). As such, I am going to close this PR and reuse the Jira ticket for the animation PR.

Thanks for the advice!

Filippo Zazzeroni and others added 20 commits January 5, 2026 15:23

Initial Refactor for Swipe up preview

fe1b2c7

Added close button

a6ace09

Merge branch 'main' into zazza/swipe-up-tab-preview-kill-tab

29f3df3

Refactor tab preview

6a68a6a

updated Package.resolved before merge

9fd97bc

merge with main

e8c1fb8

forgot to save a file in sublime text

cc144ca

generated files and trailing whitespace fix

eea70d4

trailing whitespace fix

3b41d45

rough animation working

8906567

swiftlint fixes

2a9234f

merging main into this branch

395c0c1

polishing the animation

dabbb27

swiftlint

5b856d4

made corner radius constant during the animation

39ed280

various polishing changes around screenshot previews

316545d

fixed screenshot cropping bug

2292f47

feature flag stuff

9cfe8e3

swiftlint

ded8550

ironing out some bugs

8df5016

Alex-Bangu requested a review from FilippoZazzeroni July 6, 2026 16:03

Alex-Bangu requested a review from a team as a code owner July 6, 2026 16:03

Merge branch 'main' into abangu/swipe-up-address-bar-animation

748f2cc

FilippoZazzeroni reviewed Jul 7, 2026

View reviewed changes

Merge branch 'main' into abangu/swipe-up-address-bar-animation

39852d9

Merging main

OrlaM requested changes Jul 10, 2026

View reviewed changes

Alex-Bangu closed this Jul 10, 2026


		// MARK: - UIGestureRecognizerDelegate

		func gestureRecognizerShouldBegin(_ gestureRecognizer: UIGestureRecognizer) -> Bool {

Uh oh!

Conversation

Alex-Bangu commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Tickets

💡 Description

🎥 Demos

📝 Checklist

Uh oh!

mergify Bot commented Jul 6, 2026

Uh oh!

mobiletest-ci-bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Code coverage

🧩 Neat Piece

💬 Description craftsman

🦊 BrowserViewController Check

Client.app: Coverage: 43.51

Uh oh!

PARAIPAN9 commented Jul 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OrlaM left a comment

Choose a reason for hiding this comment

Uh oh!

Alex-Bangu commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Alex-Bangu commented Jul 6, 2026 •

edited

Loading

mobiletest-ci-bot commented Jul 6, 2026 •

edited

Loading