Add FXIOS-14379 [Performance] Add back equatable for BVC state #31217
+25
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cramsden
changed the title
ih-codes
approved these changes
Dec 10, 2025
Collaborator
ih-codes
left a comment
ih-codes
left a comment
There was a problem hiding this comment.
Thanks for fixing the issue with ShareTab Equatable!
| // Setting default page as topsites | ||
| var newTabPageType: NewTabPage = .topSites | ||
| var tabUUID: TabUUID = UUID().uuidString | ||
| // TODO: FXIOS- This can't be nonisolated because it is a var but it is only set once. |
| import Foundation | ||
|
|
||
| protocol ShareTab: Sendable { | ||
| nonisolated var tabUUID: TabUUID { get } |
Collaborator
There was a problem hiding this comment.
Nice, seems a reasonable solution for this weird edge case! 👌
lmarceau
approved these changes
Dec 10, 2025
Contributor
lmarceau
left a comment
lmarceau
left a comment
There was a problem hiding this comment.
+1 on what Isabella said already!
Cramsden
force-pushed
the
cr/FXIOS-14379_add-back-equatable-to-bvc-state
branch
from
6094f26 to
9debf5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
💡 Description
Add back equatable to BVC state so that we can do redux diffing. Because ShareTab has a webview and has to be main actor isolated I had to add a nonisolated ID property to equate on.
🎥 Demos
Demo
📝 Checklist