-
Notifications
You must be signed in to change notification settings - Fork 3.1k
EXP-5874 Add strings for Rollouts toggle and update Studies strings #31198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXP-5874 Add strings for Rollouts toggle and update Studies strings #31198
Conversation
af44d74 to
a17d194
Compare
a17d194 to
2bd1ffd
Compare
|
Should be ready for the final review! Thanks @razvanlitianu for helping with this! |
razvanlitianu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
|
Oops, moving the strings caused a compilation error because the structure change. I think in this case it's ok to keep them side by side, and move them to the deprecation section only when we actually replace them and they are no longer needed. |
2bd1ffd to
d7e6457
Compare
|
I can't merge I believe! I added the changes! |
firefox-ios/Shared/Strings.swift
Outdated
| value: "Close", | ||
| comment: "This is the swipe action title for closing an inactive tab by swiping, located in the Inactive Tabs section of the Tabs Tray") | ||
| } | ||
| struct v148 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build still failing. Can we also move these back?
d7e6457 to
c6d2bbb
Compare
✍️ Strings UpdatedDetected changes in 🧹 Tidy commitJust 5 file(s) touched. Thanks for keeping it clean and review-friendly! 🙌 Friday high-fiveThanks for pushing us across the finish line this week! 🙌 ❌ Per-file test coverage gateThe following changed file(s) are below 35.0% coverage:
Generated by 🚫 Danger Swift against ec30185 |
|
This swiftlint error looks.... suspicious? Also, seems like the IDE I am using is handling |
c6d2bbb to
598e950
Compare
|
I just use the default straight quotes from Xcode. If your editor converts them, check the Smart Quotes setting in Xcode or macOS. |
598e950 to
00b6b6e
Compare
|
Not sure why this fails again... |
|
@mergify rebase |
✅ Branch has been successfully rebased |
00b6b6e to
21b1fa8
Compare
|
Seems like Glean can't be pulled: |
|
@mergify rebase |
✅ Branch has been successfully rebased |
21b1fa8 to
ec30185
Compare
|
🚀 PR merged to |
|
@gruberb, thanks for your patience. It seems like some systems were malfunctioning. Finally, the checks passed, and I was able to merge the changes. |
Add Strings for v148, as a base for the split of studies toggle in #30988
📜 Tickets
Jira ticket
Bugzilla issue
💡 Description
See #30988 for full changes.
📝 Checklist