Skip to content

Conversation

@yoanarios
Copy link
Contributor

πŸ“œ Tickets

Jira ticket
Github issue

πŸ’‘ Description

  • Add changes made for minimal address bar for Tab scroll refactor
  • Fixes iPad logic

πŸ“ Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@yoanarios yoanarios requested a review from PARAIPAN9 December 5, 2025 21:29
@yoanarios yoanarios force-pushed the yrd/FXIOS-14105-Minimal-Address-Bar-update-new-Design-refactor branch from 307bd82 to 216ffa7 Compare December 8, 2025 15:41
@mobiletest-ci-bot
Copy link

Messages
πŸ“– Project coverage: 37.93%

🧹 Tidy commit

Just 3 file(s) touched. Thanks for keeping it clean and review-friendly!

❌ Per-file test coverage gate

The following changed file(s) are below 35.0% coverage:

File Coverage Required
firefox-ios/Client/Frontend/Browser/BrowserViewController/Extensions/BrowserViewController+TabScrollHandlerDelegate.swift 0.0% 35.0%

Client.app: Coverage: 36.94

File Coverage
ToolbarViewProtocol.swift 81.71% βœ…
TabScrollHandler.swift 74.58% βœ…
BrowserViewController+TabScrollHandlerDelegate.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 216ffa7

@yoanarios yoanarios marked this pull request as ready for review December 8, 2025 15:55
@yoanarios yoanarios requested a review from a team as a code owner December 8, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants