Bugfix FXIOS-8657 Add operation queue to perform batch updates #19670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client.app: Coverage: 30.8
Generated by 🚫 Danger Swift against ae05903 |
thatswinnie
reviewed
Apr 8, 2024
firefox-ios/Client/Frontend/Browser/Tabs/TabTrayAnimationQueue.swift
Outdated
Show resolved
Hide resolved
thatswinnie
approved these changes
Apr 8, 2024
… to TabDisplayView
dataports
force-pushed
the
sa/Add-operation-queue-to-perform-batch-updates
branch
from
47fa8a4
to
07e88a2
Compare
|
This pull request has conflicts when rebasing. Could you fix it @OrlaM? 🙏 |
6 tasks
|
This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions! |
github-actions
bot
added
the
stale
…Add-operation-queue-to-perform-batch-updates # Conflicts: # firefox-ios/Client/Frontend/Browser/Tabs/Action/TabPanelAction.swift # firefox-ios/Client/Frontend/Browser/Tabs/State/TabsPanelState.swift # firefox-ios/Client/Frontend/Browser/Tabs/Views/TabDisplayView.swift # firefox-ios/Client/Frontend/Browser/Tabs/Views/TabTrayViewController.swift
|
@Mergifyio backport release/v126 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Remove collectionView updates in newState of TabDisplayView * Make performChainedOperations var private and add template of methods to TabDisplayView * Add updateWith for moving the tab * Add updateWith * WIP * didAddTab called in TabDisplayView * Clean up operation queue * Remove commented code * Fix crash when there's no sections --------- Co-authored-by: Sophie Amin <samin@KPQ47DG99L.lan> (cherry picked from commit 86bd353)
6 tasks
OrlaM
added a commit
that referenced
this pull request
Apr 30, 2024
… (#20096) * Remove collectionView updates in newState of TabDisplayView * Make performChainedOperations var private and add template of methods to TabDisplayView * Add updateWith for moving the tab * Add updateWith * WIP * didAddTab called in TabDisplayView * Clean up operation queue * Remove commented code * Fix crash when there's no sections --------- Co-authored-by: Sophie Amin <samin@KPQ47DG99L.lan> (cherry picked from commit 86bd353) Co-authored-by: OrlaM <omitchell@mozilla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Fixes some of the bugs around dragging and drop tabs and animations in general
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)