Refactor MTE-1208 [v123] navigation tests with TR #17981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against c55cbb6 |
isabelrios
reviewed
Jan 8, 2024
| @@ -403,7 +413,7 @@ class NavigationTest: BaseTestCase { | |||
| XCTAssert(app.keyboards.count > 0, "The keyboard is not shown") | |||
| app.typeText("example.com\n") | |||
|
|
|||
| // waitUntilPageLoad() | |||
| // waitUntilPageLoad() | |||
There was a problem hiding this comment.
Nit: can we remove this instead of leaving it commented?
There was a problem hiding this comment.
I can update this in the next PR if that is ok with you.
isabelrios
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
💡 Description
Data alignment for navigation tests with TR. Below screenshots results are for testScrollsToTopWithMultipleTabs that has been modified to use the newly added function scrollToElement.
https://docs.google.com/document/d/14nhRcn4PtHFo1VMGh9w6FPpyOUjgElw751JU0yuuuw0/edit#heading=h.i26ccowgusqi
https://testrail.stage.mozaws.net/index.php?/suites/view/45443&group_by=cases:section_id&group_order=asc&group_id=426835