Refactor FXIOS-7845 [v122] Remove shared TabManager, use dependency injection #17607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -246,7 +238,6 @@ class AppDelegate: UIResponder, UIApplicationDelegate { | |||
| singleShotTimer.resume() | |||
| shutdownWebServer = singleShotTimer | |||
| backgroundWorkUtility?.scheduleOnAppBackground() | |||
| tabManager.preserveTabs() | |||
There was a problem hiding this comment.
Note: removal of this was intentional, it has been moved into BrowserViewController.swift
| @@ -232,7 +225,6 @@ class AppDelegate: UIResponder, UIApplicationDelegate { | |||
|
|
|||
| handleBackgroundEvent() | |||
| TelemetryWrapper.recordEvent(category: .action, method: .background, object: .app) | |||
| TabsQuantityTelemetry.trackTabsQuantity(tabManager: tabManager) | |||
There was a problem hiding this comment.
Note: removal of this was intentional, it has been moved into BrowserViewController.swift
|
This pull request has conflicts when rebasing. Could you fix it @mattreaganmozilla? 🙏 |
… use individual instances passed via DI, one for each BVC. For currently iOS app this should have no change, but it helps pave the way for forthcoming multiwindow support for iPad.
mattreaganmozilla
force-pushed
the
mr/7784_early_multiwindow_refactors
branch
from
1eb77c7
to
84209e6
Compare
OrlaM
approved these changes
Dec 5, 2023
|
It looks like there are quite a few updates needed to the unit (& UI) tests to support this refactor, working on that now. |
…w require passing in TabManager via DI
mattreaganmozilla
force-pushed
the
mr/7784_early_multiwindow_refactors
branch
from
ad19b8e
to
3f2b3fc
Compare
Client.app: Coverage: 32.1
Generated by 🚫 Danger Swift against 34a82d0 |
… one of the failing UI tests.
yoanarios
approved these changes
Dec 6, 2023
d4r1091
added a commit
to ecosia/ios-browser
that referenced
this pull request
Feb 14, 2024
Squashed commit of the following:
commit 71445cd847fe6f2cf60d9917d2da12d4a5061524
Author: Donal Meehan <76789979+DonalMe@users.noreply.github.com>
Date: Tue Feb 6 10:54:16 2024 -0500
Bump [v122] Set version to 122.3 (#18596)
commit 7475f2cbaf05ffc571ddeb222e5aed79e2b3a36e
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Mon Feb 5 10:27:20 2024 -0500
Bugfix FXIOS-8334 [v122.1] Users can be moved from private browsing tabs to regular tabs with prefer switch to open tab enabled (backport #18513) (#18544)
* Bugfix FXIOS-8334 [v122.1] Users can be moved from private browsing tabs to regular tabs with prefer switch to open tab enabled (#18513)
* FXIOS-8334 #18469 Users can be moved from private browsing tabs to regular tabs, with prefer-switch-to-open-tab enabled
* Revert method on tab manager
(cherry picked from commit 6c72365bbb4a11e825494e280599791afd9e188e)
# Conflicts:
# Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
* Remove spaces
* Add missing code changes
---------
Co-authored-by: Litianu Razvan <litianu.razvan@gmail.com>
commit 8956b23853c3e4c1823a4df7ea2e7aad4683b43b
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Mon Feb 5 09:04:56 2024 -0500
Bugfix FXIOS-7850 [v122] Show search suggestions and engines in private mode (#18176) (#18179)
(cherry picked from commit cc9329361a61f7deaa8df861b37eb79ddb965ad5)
Co-authored-by: Cyndi Chin <cgc95@cornell.edu>
commit 32635ec11096239a763c2bd92ed78c73c273241d
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Mon Feb 5 09:04:20 2024 -0500
Add FXIOS-6836 [v122.1] Prefer switching to open tabs vs opening a duplicate tab (backport #18073) (#18534)
* Add FXIOS-6836 [v123] Prefer switching to open tabs vs opening a duplicate tab (#18073)
* FXIOS-6836 #15236 We should prefer switching to open tabs vs opening a duplicate tab
* fix compilation due to merge conflict
* Move nimbus configuration
* Update homescreenFeature
(cherry picked from commit d4c5294fe077be89be428ad763f8acae5572fc41)
# Conflicts:
# Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
* Fix conflict
---------
Co-authored-by: Litianu Razvan <litianu.razvan@gmail.com>
commit 6b4e45cc05dffc3c5be9424bd332f8faf33100a7
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Fri Feb 2 18:49:57 2024 +0000
Refactor [v122.2] Update initial experiments JSON for Nimbus (#18550)
Co-authored-by: isabelrios <isabelrios@users.noreply.github.com>
(cherry picked from commit 04431b65b22136e3b9eaed437d5ad3317f242ac6)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit 20a7456121b90d5360f9d8e081c06331438e50cd
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Wed Jan 31 09:06:22 2024 -0500
Refactor [v122.2] Update initial experiments JSON for Nimbus (#18477) (#18478)
Co-authored-by: isabelrios <isabelrios@users.noreply.github.com>
(cherry picked from commit 47c13f933f578e15b7ddaa365330b5eaa176bc4a)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit 0149b58ff76307ca1837ed3b6c996fea97c6afe0
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Wed Jan 31 09:06:01 2024 -0500
Refactor [v122.2] Update initial experiments JSON for Nimbus (#18480) (#18481)
Co-authored-by: isabelrios <isabelrios@users.noreply.github.com>
(cherry picked from commit 729e1af7d5baf3c3e1d2efa246a8e147012d6cd3)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit 23009c905f20b5e649b1e7039ce301b9adac986c
Author: Donal Meehan <76789979+DonalMe@users.noreply.github.com>
Date: Tue Jan 30 10:35:17 2024 -0500
Bump [v122] Set version to 122.2 (#18473)
commit 65ae98399b4f27ebf5dd6a94aadb2b29c690f282
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Tue Jan 23 16:48:58 2024 -0500
Refactor [v122.1] Update initial experiments JSON for Nimbus (#18329)
Co-authored-by: isabelrios <isabelrios@users.noreply.github.com>
(cherry picked from commit cd982ae67e9c827ad76f0b5fd730f2253ad4a11f)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit ce3df62ee21502411bd907ebc5fb28a992bb95d3
Author: Donal Meehan <76789979+DonalMe@users.noreply.github.com>
Date: Fri Jan 19 13:44:32 2024 -0500
Bump [v122] Set version to 122.1 (#18260)
commit 40105277676fdc44198325e6cf1e4b3bd343e283
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Mon Jan 15 11:48:57 2024 -0500
Bugfix FXIOS-8103 [v122] Fix bug in AppEventQueue causing some actions to be skipped (#18133) (#18149)
* [8103] Fix issue where AppEventQueue was potentially skipping enqueued action blocks due to them being enqueued while already processing actions AND if all dependencies were already satisfied
* [8103] Add unit test
(cherry picked from commit 14d6f9659277e56b6f91ef652c1fd86613f376c7)
Co-authored-by: mattreaganmozilla <145381717+mattreaganmozilla@users.noreply.github.com>
commit 73e647d5b6e15de67ae754cf6e1ef05d4d740e72
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Mon Jan 15 11:44:14 2024 -0500
Localize [v122] String import 2024-01-15 (#18151)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit 33456751dc1ec3496166c6a96fe4ff4c46f4d17b
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Fri Jan 12 12:42:27 2024 -0500
Refactor [v122] Update initial experiments JSON for Nimbus (backport #18121) (#18123)
Co-authored-by: OrlaM <OrlaM@users.noreply.github.com>
(cherry picked from commit 9375205bda5cb0a9d94f6fdf05b44f3fadef7b01)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit 6060624579b89b77f903a6e8752468823e2812b6
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Fri Jan 12 13:18:43 2024 +0000
Add FXIOS-8065 [v122] Send trusted_deals_placement upon fetching the Fakespot ad unit from a server (backport #18051) (#18077)
* Add FXIOS-8065 [v122] Send trusted_deals_placement upon fetching the Fakespot ad unit from a server (#18051)
* FXIOS-8065 #17974 Send trusted_deals_placement upon fetching the Fakespot ad unit from a server
* Update on trusted deal placement
(cherry picked from commit 00c6eda8d6fda968489eb2edd62fa75db31966be)
# Conflicts:
# firefox-ios/firefox-ios-tests/Tests/ClientTests/ShoppingProductTests.swift
* Fix conflicts
---------
Co-authored-by: Litianu Razvan <litianu.razvan@gmail.com>
commit cfe487af3c7c74bf1b4858e07f0a5e1157cd87e9
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Fri Jan 12 05:04:53 2024 -0500
Bugfix FXIOS-8100 [v122] [Fakespot] Crashes when changing from portrait to landscape mode while review drawer is opened and an ad is displayed (backport #18098) (#18116)
* Bugfix FXIOS-8100 [v122] [Fakespot] Crashes when changing from portrait to landscape mode while review drawer is opened and an ad is displayed (#18098)
* Remove empty group
* Add a11y id for star rating
* Move code around
* Update ad layout to fix crash
* Update title spacing
* Fix Swiftlint warnings
* Fix spelling
(cherry picked from commit 48ea2a320fd8a37a4c148f6028249c0f8caf1cf1)
# Conflicts:
# Client/Frontend/Fakespot/FakespotViewModel.swift
# Client/Frontend/Fakespot/Views/FakespotAdView.swift
* Fix merge conflict
* Solve merge conflict
---------
Co-authored-by: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>
commit 12a635496556a74863dcf47dd2ff8f6b9fe68ef6
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Thu Jan 11 16:15:37 2024 -0500
Bugfix FXIOS-7997 [v122] [Felt Deletion] Update CFR to only display for webpage (#18102) (#18106)
* Bugfix FXIOS-7997 [v122] Update CFR to only display for webpage
* set type to be private over internal
(cherry picked from commit a64c5a1cb15f545e5367e6a43ac9799809aaed91)
Co-authored-by: Cyndi Chin <cgc95@cornell.edu>
commit 897a62e94ec10134cfe19a9bdd174d78e751b3e6
Author: Donal Meehan <76789979+DonalMe@users.noreply.github.com>
Date: Thu Jan 11 14:57:59 2024 -0500
Bump [v122] Upgrades App Services to 122.0.2 (#18105)
commit 86bde8f72cf7f5478ae63b00e7d79ce08daaeee2
Author: Cyndi Chin <cgc95@cornell.edu>
Date: Thu Jan 11 13:30:22 2024 -0500
Bugfix FXIOS-8128 [v122] Move fire icon to proper location (#18104)
commit 8655646fe061c89bd41ff091afc786956a727198
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Thu Jan 11 08:17:01 2024 -0500
Add FXIOS-8096 [v122] Telemetry for data clearance button (backport #18080) (#18087)
commit 4d3f91343d15fdd95b9a375c9d1ca102f3952407
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Wed Jan 10 20:01:33 2024 -0500
Bugfix FXIOS-8125 [v122] Fix customizeHomepageButton telemetry (#18068) (#18093)
---------
Co-authored-by: Nishant Bhasin <nish.bhasin@gmail.com>
(cherry picked from commit 38aa32997a11d0ca8f99f9621ff34910922bef9a)
Co-authored-by: Daniela Arcese <dnarcese@gmail.com>
commit 6cc202028bbf9c91632591a1a200f973a0ab9ad0
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Wed Jan 10 17:53:24 2024 -0500
Add FXIOS-7879 [v122] Redux & private theme (backport #18083) (#18091)
* Add FXIOS-7879 [v122] Redux & private theme (#18083)
* Add theming
* fixes & additions
* Fix bug!
* Swiftlint, my child, why do you hate me
* Forgot one teensy thing
(cherry picked from commit e437f90f2a0a4960cb11dcf2e2ca15d1b9d20715)
# Conflicts:
# Client/Frontend/Home/PrivateHome/PrivateHomepageViewController.swift
* Update PrivateHomepageViewController.swift
---------
Co-authored-by: roux g. buciu <11182210+adudenamedruby@users.noreply.github.com>
commit de962e014a7201d9a650b74dc7b10a8f63127228
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Wed Jan 10 00:51:38 2024 +0000
Refactor FXIOS-8107 [v121.2] Disable recently visited section and loading of the history highlights (backport #18060) (#18070)
* Refactor FXIOS-8107 [v121.2] Disable recently visited section and loading of the history highlights (#18060)
* Refactor FXIOS-8107 [v121.2] Disable recently visited section and loading of the history highlights
* lint fix
* lint fixes
* test fixes
* test fixes v2
* test fixes v3
* test fixes v4
* Disabled full test
---------
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 597220a0b9a6dd9c2a67db5252fc781ee4aaaea5)
# Conflicts:
# firefox-ios/firefox-ios-tests/Tests/XCUITests/HomePageSettingsUITest.swift
* fix merge conflicts
---------
Co-authored-by: Nishant Bhasin <nish.bhasin@gmail.com>
commit 2313060e5800a11bbefae31fa7ea0a6c93a38c04
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Tue Jan 9 11:52:30 2024 -0500
Bugfix FXIOS-7497 [v121] Fix scroll bug (backport #18048) (#18057)
* Bugfix FXIOS-7497 [v121] Fix scroll bug (#18048)
(cherry picked from commit e9210c5204a3395ec735cc4a23634d1c364db8d4)
# Conflicts:
# Client/Frontend/Browser/TabScrollController.swift
* Fix conflict
---------
Co-authored-by: OrlaM <omitchell@mozilla.com>
commit 0cf3402a5e6a11b3e2944aa90096f0e188dfc72b
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Tue Jan 9 10:02:42 2024 -0500
Bugfix FXIOS-8105 [v121] Fix Send to Device failing intermittently (#18042) (#18050)
* [8105] Fix issue where Send to Device could fail because RustFXAccounts startup flow not yet completed
* [8105] Additional work to fix issue with Send to Device sometimes failing, be sure we check for nil account manager not hasAccount(), the latter will be false when users are signed out
* [8105] Cleanup, remove unnecessary code and explicit self references
* [8105] Additional cleanup, restore self references where needed to avoid local variable shadowing
(cherry picked from commit 86ad3adbe83040568bf39567e33fbd8e4797c8b6)
Co-authored-by: mattreaganmozilla <145381717+mattreaganmozilla@users.noreply.github.com>
commit c8e9adbecf5bbc5b334e8d36b51b1d758af540f3
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Mon Jan 8 13:16:28 2024 -0500
Refactor FXIOS-8102 [v122] Felt privacy work to use redux to show a feature (#18030) (#18032)
(cherry picked from commit 288b87c1553d20f742634a09e9fcb6678221cd28)
Co-authored-by: Cyndi Chin <cgc95@cornell.edu>
commit 31cccf21bc2e7311e5134ce20212fe3b91c45cb7
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Fri Jan 5 12:37:16 2024 -0500
Localize [release/v1] String import 2024-01-05 (#18010)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit da81c476ab39294b577214051524b0b87e9558a3
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Wed Jan 3 15:47:21 2024 -0500
Add FXIOS-7997 [v122] CFR for fire button (#17948) (#17975)
* Add FXIOS-7868 [v122] CFR for fire button
* add unit tests
* cleanup code
(cherry picked from commit 1ed336cd05634b3ef4ead14f6a5cadcc6929e78f)
Co-authored-by: Cyndi Chin <cgc95@cornell.edu>
commit 0a9bca9e861821a9a4174e33f4730b4ad0c685e8
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Wed Jan 3 15:29:16 2024 -0500
Add FXIOS-7752 [v122] Add telemetry for surface ads clicked (#17861) (#17970)
* Add FXIOS-7752 [v122] Add telemetry for surface ads clicked
* Update pr number
(cherry picked from commit 96e9a4a0e9a33c0aaebeca68f99ccaa54c690a1b)
Co-authored-by: Litianu Razvan <litianu.razvan@gmail.com>
commit 7ea767d7ee69b89f2d101653c18af49845f87fe4
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Tue Jan 2 15:33:09 2024 -0500
Revert logins key logic updates (#17954) (#17961)
(cherry picked from commit bc7f27a9fe671409617c4abbebb78ab8d4687126)
Co-authored-by: lougeniaC64 <lougeniaC64@users.noreply.github.com>
commit 0f0289735d53697a27d77c908b0cbe8629ae8a05
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Thu Dec 28 15:50:50 2023 -0500
Add FXIOS-7869 [v122] Delete data alert for fire icon (#17940) (#17943)
(cherry picked from commit 3c15a6cec4c646e91053e0ce489916ba393aa71f)
Co-authored-by: Cyndi Chin <cgc95@cornell.edu>
commit e34ff28b33d4f7fb126fd6ca3e25dec2bfc5977e
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Thu Dec 28 11:18:39 2023 -0500
Add FXIOS-7944 [v122] Add Webview telemetry for failures (backport #17910) (#17939)
* Add FXIOS-7944 [v122] Add Webview telemetry for failures (#17910)
(cherry picked from commit 2d33ee8e4300d12eeac5ba27162cb0a094fdc3f7)
# Conflicts:
# .swiftlint.yml
# Client/Telemetry/TelemetryWrapper.swift
# Client/metrics.yaml
* fixed merge conflicts
---------
Co-authored-by: lmarceau <lmarceau@mozilla.com>
Co-authored-by: Nishant Bhasin <nish.bhasin@gmail.com>
commit 07b0e5b8cc296859098eb5159006389da9b9ee6c
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Thu Dec 28 10:21:33 2023 -0500
Add FXIOS-7994 [v122] Data clearance check to redux (backport #17876) (#17904)
* Add FXIOS-7994 [v122] Data clearance check to redux (#17876)
(cherry picked from commit a3bbeb11466020f9735725bb1236a43a50adb682)
* resolve build issues
---------
Co-authored-by: Cyndi Chin <cgc95@cornell.edu>
commit 505750a0ce90fc44187a025a92bd43e3097f89ed
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Thu Dec 21 15:57:33 2023 -0500
Bugfix FXIOS-8006 [v122] Fix homepage loading issue (#17873) (#17874)
* Squishy da bug
* Format things like a civilized human being
---------
Co-authored-by: roux g. buciu <github@fringe.foundation>
(cherry picked from commit ccbf3a90e1705f1d276cbc083bde23917f14834e)
Co-authored-by: roux g. buciu <11182210+adudenamedruby@users.noreply.github.com>
commit 78c193c0889a9e4af086ba3def4035d04720417c
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Thu Dec 21 15:57:22 2023 -0500
Add FXIOS-8005 [v122] Subtitle to Show Suggestions setting (#17870) (#17875)
(cherry picked from commit 21c2e82e48e2aa55d147af6934bbeb7bcccc4817)
Co-authored-by: Cyndi Chin <cgc95@cornell.edu>
commit a89ed2f86b8b7c71252bf8f34a7b5239dbbe0f6c
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Thu Dec 21 11:53:10 2023 -0500
Add FXIOS-7866 [v122] Fire icon to private mode (#17843) (#17868)
* Add FXIOS-7986 [v122] Fire icon to private mode
* add accessibility label for fire icon
* consolidate cases for feature flag
(cherry picked from commit ff2981870f205103633dd7b77b8f034acbf3239e)
Co-authored-by: Cyndi Chin <cgc95@cornell.edu>
commit fcf46fe031197a5f2c41d71e0a7de5909723b439
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Thu Dec 21 11:34:43 2023 -0500
Added FXIOS-7559 [v121] health metrics telemetry (backport #17844) (#17865)
* Added FXIOS-7559 [v121] health metrics telemetry (#17844)
* Add crashed last launch metric
* Add cpu exception telemetry
* Add hang exception
* Update link
* Fix warning
* Update links
(cherry picked from commit 0898ac8e9d4729b1c42257f7f793bf66f27c5299)
# Conflicts:
# Client/Telemetry/TelemetryWrapper.swift
# Client/metrics.yaml
* Fix conflicts
---------
Co-authored-by: OrlaM <omitchell@mozilla.com>
Co-authored-by: Laurie Marceau <lmarceau@mozilla.com>
commit bcef02b4144e6a79fcfe5f5c552297762260fb3f
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Wed Dec 20 16:04:13 2023 -0500
Bugfix FXIOS-7984 [v121]: Makes sure networking is enabled in ShareTo (#17849) (#17855)
(cherry picked from commit fec6cc0804dbf565aad0ebfb60641781e4beb1be)
Co-authored-by: Tarik Eshaq <teshaq@mozilla.com>
commit e003658d43985b26922ac3b8afca618bb4e34835
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Wed Dec 20 13:25:30 2023 -0500
Bugfix FXIOS-7983 [v121] url hang (#17842) (#17846)
* Fix URL hang
* Revert "Fix URL hang"
This reverts commit c473ef7db073aa99eb875648a5bd645fe2fcf792.
* Fix url hang
(cherry picked from commit f8bd270d19cce65677d52bc9c45bc1b84049eefc)
Co-authored-by: OrlaM <omitchell@mozilla.com>
commit 1204986c443697bfc5fcc17acddce26be9929a06
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Wed Dec 20 12:54:20 2023 -0500
Fix MTE-2029 [v123] testSharePageWithShareSheetOptions in Ipad (#17822) (#17834)
* Fix MTE-2029 [v123] testSharePageWithShareSheetOptions in Ipad
* Lint issue with var vs let
---------
Co-authored-by: Clare So <cso@mozilla.com>
(cherry picked from commit 6d7d1d6f8721c359c5ce122bb3ce25067384e9e9)
Co-authored-by: dragosb01 <134391433+dragosb01@users.noreply.github.com>
commit 6205135443b35856f192c79bb6aca64f0955ccbb
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Wed Dec 20 10:18:45 2023 -0500
Bugfix FXIOS-6815 [v122] Add link to home screen option not available (#17836) (#17837)
(cherry picked from commit 77b4c710f0ce4d6c201d9adfa2e28f6275b48767)
Co-authored-by: Litianu Razvan <litianu.razvan@gmail.com>
commit a73b31eb5fa78a62565621fb1de660f4abd87ac7
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Tue Dec 19 15:29:48 2023 -0500
Disabled MTE-2024 [v123] flaky tests (backport #17817) (#17829)
* Disabled MTE-2024 flaky tests (#17817)
(cherry picked from commit cda058c35e8d91590efde9a174b86b206988fdf5)
# Conflicts:
# firefox-ios/firefox-ios-tests/Tests/XCUITests/PhotonActionSheetTests.swift
* Resolve merge conflict
---------
Co-authored-by: dragosb01 <134391433+dragosb01@users.noreply.github.com>
Co-authored-by: Clare So <cso@mozilla.com>
commit ed9055bc9cc31e30f92a84db6371309759f8d728
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Tue Dec 19 13:09:55 2023 -0500
Bugfix FXIOS-7985 [v122] Display 3 lines of title for ads (#17819) (#17828)
* Restrict lines of title for LinkButton
* Update colors like in other button
* Add comments
* Restrict number of lines for ad link
* Add FakespotAdLinkButton
* Use new button
* Remove new code
* Simplify code
(cherry picked from commit aba3d153d58f8f054011228f947e90b4b979ed4b)
Co-authored-by: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>
commit 9e6548f22a08291af0ab741e4ab94ab0783b9fda
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Tue Dec 19 12:24:34 2023 -0500
Add FXIOS-7991 [v122] Add custom targeting attribute for review checker being enabled for user (backport #17824) (#17826)
* Add FXIOS-7991 [v122] Add custom targeting attribute for review checker being enabled for user (#17824)
* Add custom targeting for review checker
* Remove force unwrap
* Update warning threshold
(cherry picked from commit c8a7c7d1a04a3b9e482f5d239d54d08650ec95bf)
# Conflicts:
# test-fixtures/generate-metrics.sh
* Fix merge conflicts
---------
Co-authored-by: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>
commit f9e3e482d6001e36d92be197bb11ee246f14046a
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Mon Dec 18 13:21:00 2023 -0500
Localize [release/v122] String import 2023-12-18 (#17807)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit 55fecb36ddb6ac835a0bcf19caf7b24db6893336
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Mon Dec 18 13:19:58 2023 -0500
Refactor FXIOS-7936 [v122] HomeLogoHeaderCell to be reusable + adjust padding (#17799) (#17805)
* Refactor FXIOS-7936 [v122] HomeLogoHeaderCell to be reusable
* adjust constraints for multitasking
(cherry picked from commit 6d48d723680e0957a29b0ca0c16098a9270b8e9c)
Co-authored-by: Cyndi Chin <cgc95@cornell.edu>
commit 395339524c76b9d7650909bc048a60c4051d9150
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date: Mon Dec 18 13:17:57 2023 -0500
Remove FXIOS-7979 [v122] Redux feature flag (#17797) (#17804)
* Remove redux feature flag
* Remove unnecessary async call from middleware
* Swiftlint warning
(cherry picked from commit 2b74124ed6cc4000544ec78f4ecc5906b9a928b4)
Co-authored-by: yoanarios <yriosdiaz@mozilla.com>
commit 86652d5c093d12ec2d4e503075d1f20edf20d7a7
Author: Donal Meehan <76789979+DonalMe@users.noreply.github.com>
Date: Mon Dec 18 13:16:11 2023 -0500
Bump [v122] Upgrades App Services to 122.0 (#17806)
commit 0c825361c035dc0cb1bbae05d71f14f5a21c72d7
Author: OrlaM <omitchell@mozilla.com>
Date: Mon Dec 18 12:18:41 2023 -0500
Added FXIOS-7859 [v122] tab peek preview redux (#17770)
* Add initial wiring for redux on tab peek
* Wire up the initial redux actions for peek
* Remove unused code
commit 35985ff7b7d24bed715ab716fd0d7530ea140ad5
Author: imsanchit <sanchitmittal18@gmail.com>
Date: Mon Dec 18 21:55:51 2023 +0530
Bugfix FXIOS-6685 [v122] Search is not correctly aligned in RTL locale (ar) (#17632)
commit 20c350cd947fffbeef1cfd7b81dd378eb4bfad97
Author: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>
Date: Mon Dec 18 17:11:32 2023 +0100
Bugfix FXIOS-7967 [v122] Address ad design review feedback (#17792)
* Add corner radius to product image
* Update font sizes and spacing
* Set button theme correctly
commit aa1dc77bcc545e737c0dc7be55dcd58e1625fa4d
Author: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>
Date: Mon Dec 18 16:49:09 2023 +0100
Bugfix FXIOS-7977 [v122] Fakespot - Sidebar incorrectly opens on a non-PDP page after a specific scenario (#17798)
commit a4647602e8eb5a5421caccedbe676ac826178663
Author: Mihai Bolojan <74779930+bmihai23@users.noreply.github.com>
Date: Mon Dec 18 17:43:31 2023 +0200
Refactor FXIOS-7938 [v122] Remove SnapKit from SettingsTableViewController file (#17788)
* Remove SnapKit and Refactor Code in SettingsTableViewController
* Replace fileprivate with private for access control consistency
* Address minor nits and improve code style based on feedback
commit cd88ca37c3f9f4da1efff2a107dbeb7a2c23a64c
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Mon Dec 18 09:51:03 2023 -0500
Localize [v122] String import 2023-12-18 (#17794)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit 59d9942e49c3a60e5aeac0b6dc0be9b7f59f3597
Author: roux g. buciu <11182210+adudenamedruby@users.noreply.github.com>
Date: Mon Dec 18 09:46:13 2023 -0500
Bugfix FXIOS-7663 [v122] Fix "Now Now" to "Not Now" (#17796)
Co-authored-by: roux g. buciu <github@fringe.foundation>
commit a597e125edf93a266cbf3c8aad6ecd1e8db77ad9
Author: isabelrios <isabelrios@gmail.com>
Date: Mon Dec 18 14:25:12 2023 +0100
Refactor MTE-1206 [v123] ActivityStream TestRail matching (#17793)
* Refactor MTE-1206 [v123] ActivityStream TestRail matching
* remove test as it can be added as a step
* remove test as it can be added as a step2
commit 894dda6ea306c86a62f37eb1e98df4fc0a1b28b7
Author: dragosb01 <134391433+dragosb01@users.noreply.github.com>
Date: Mon Dec 18 13:12:12 2023 +0200
Refactor MTE-1209 [v122] search tests with TR (#17790)
commit fc57b30957f6bf6e0328b883ee3c1e8751c61528
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Mon Dec 18 12:01:32 2023 +0100
Auto update SPM with latest rust-component release 122.0.20231216050351 (#17786)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit fe9936fe52b453a4bf963fbe047bd04967301509
Author: mattreaganmozilla <145381717+mattreaganmozilla@users.noreply.github.com>
Date: Fri Dec 15 13:05:47 2023 -0800
Refactor FXIOS-7798 [v122] Remove hardcoded window UUID (Multi-window support) (#17771)
* Minor refactor and rename to help clarify the intent of WindowManager APIs, also added docs to protocol. WIP
* Fix linter warnings
* [7798] Remove hardcoded UUID for default single window on iOS, instead add initial support for restoring potentially more than 1 window and using unique UUIDs for each. Part of ongoing WIP for iPad multiwindow.
* [7798] Fix unit tests for related refactors in Client
* [7798] Add unit tests to WindowManager for nextAvailableUUID
* Minor cleanup for consistency
* [7798] Fix unit tests
* [7798] Fix unit tests
* [7798] Minor change to WindowManager unit tests, use a separate subject for each test rather than the shared instance created by the MockDependencyHelper so that we can reset it without potentially impacting other running tests. Also allows us to remove the reset() func on WindowManager for now which shouldn't really be necessary.
commit a1f1fe6b8242e4482da0e2bd6b3dd98638c9b395
Author: petruSt24 <126153378+petruSt24@users.noreply.github.com>
Date: Fri Dec 15 18:38:18 2023 +0200
Add FXIOS-7952 [v122] Homepage - Missing long press on Jump Back, Recently Saved - Recently Visited (#17753)
* Add FXIOS-7952 [v122] Homepage - Missing long press on Jump Back, Recently Saved - Recently Visited (#17731)
* changed sectionType
---------
Co-authored-by: Stefan Vladut <stefan.vladut@softvision.com>
commit 332746c2b2d5cc7e58cb3073470cd9133994ab9b
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Fri Dec 15 11:11:01 2023 -0500
Refactor [v122] Auto update SPM with latest rust-component 122.0.20231215050315 (#17778)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
commit 28ce4de1fd3b327e8f5a0c097ebeef2a3236502b
Author: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>
Date: Fri Dec 15 17:01:49 2023 +0100
Refactor FXIOS-7948 [v122] Update primary button highlight (#17725)
* Update stack view distribution to give buttons space for dynamic type growth
* Update background color depending on button state and use configuration
* Save background colors instead of using closure
* Update code according to PR review comments
* Update BrowserKit/Sources/ComponentLibrary/Buttons/PrimaryRoundedButton.swift
Co-authored-by: Marceau TONELLI <marceau.tonelli@gmail.com>
* Fix Swiftlint warning
---------
Co-authored-by: Marceau TONELLI <marceau.tonelli@gmail.com>
commit 67401fb9d35bac9a23b4691feecc48fb4bfbc09d
Author: roux g. buciu <11182210+adudenamedruby@users.noreply.github.com>
Date: Fri Dec 15 10:59:04 2023 -0500
Bugfix FXIOS-7884 [v122] L10N string fixes (#17777)
* First fix
* Second fixes
---------
Co-authored-by: roux g. buciu <github@fringe.foundation>
commit d59bb2f2dcd1045c10cdac9704f71f5a488271d2
Author: yoanarios <yriosdiaz@mozilla.com>
Date: Fri Dec 15 10:13:46 2023 -0500
Refactor FXIOS-6942 Listen for updates to the state from the sync tabs view controller (#17756)
commit 014cc2fc62201bb2cfa062dfbf9924ffb7371f0c
Author: Mihai Bolojan <74779930+bmihai23@users.noreply.github.com>
Date: Fri Dec 15 17:11:38 2023 +0200
Refactor FXIOS-7940 [v122] Remove SnapKit from webview delegates (#17747)
Co-authored-by: Mihai Bolojan <mihaibolojan@Mihais-MacBook-Pro.local>
commit d35f8763169708ba7cc8bdc77880c7b1b86229ab
Author: Marceau TONELLI <marceau.tonelli@epitech.eu>
Date: Fri Dec 15 15:46:16 2023 +0100
Refactor FXIOS-7702 [v122] Update SecondaryRoundedButton to use the new ResizableButton class (#17741)
* Updated SecondaryRoundedButton to use the new ResizableButton class
* Fixed wrong order of keywords
* Simplify handling of configuration updates based on state changes
* Use configuration also for background color
* Set foreground color through titleTextAttributes
* Use condensed switch syntax for setting background color
* Remove leftover corner radius and text alignment settings
* titleTextAttributes should be set in updateConfiguration
commit e0ec845c78711375ea7e434c5315a8b04f5e287e
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Fri Dec 15 07:45:06 2023 -0500
Refactor [v122] Update effective_tld_names file (#17772)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit 737e389aa3a86478bd977b13ccdc1e7394c31b72
Author: dragosb01 <134391433+dragosb01@users.noreply.github.com>
Date: Fri Dec 15 11:32:15 2023 +0200
Updated MTE-2013 [v122] login tests strings (#17773)
commit 95f7a5de483a4fcffba9bb94d78eab84312380df
Author: lmarceau <lmarceau@mozilla.com>
Date: Thu Dec 14 16:36:41 2023 -0500
Refactor FXIOS-7902 [v122] Handle session loads (#17721)
* Adding relevant code to port load URL code
* Add URLRequest tests
* Move tests for getQuery
* Ensure InternalURL works
* Fix swiftlint
* Adjust comments
* Move getQuery to Common package extension since its more general
* Create WKEngineInfo to fix test issue
* Fix comment
commit 9c6c1d3f9ea2c8ad9f9c3e90a2a9736e0e9018f7
Author: OrlaM <omitchell@mozilla.com>
Date: Thu Dec 14 16:00:59 2023 -0500
Add FXIOS-7859 [v122] Replace Legacy tab peek in new code (#17757)
commit f3f4eb37ba8ae08cf6d3c72d35cfa2094acc295a
Author: Cyndi Chin <cgc95@cornell.edu>
Date: Thu Dec 14 12:40:22 2023 -0500
Bugfix FXIOS-7968 [v122] Change private browsing suggestions toggle to be OFF by default (#17765)
* Bugfix FXIOS-7968 Change private browsing suggestions toggle to be OFF by default
* update tests
commit 05ee6a17b24ca859fa4a2f697b7dc845bd216100
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Thu Dec 14 12:03:13 2023 -0500
Refactor [v122] Auto update SPM with latest rust-component 122.0.20231214050346 (#17762)
* Auto update SPM with latest rust-component release 122.0.20231214050346
* Update Glean to v56.0.0
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Ryan VanderMeulen <rvandermeulen@mozilla.com>
commit 813fa6323b33c68b236525656a504c185a33a5fc
Author: Nishant Bhasin <nish.bhasin@gmail.com>
Date: Thu Dec 14 11:38:52 2023 -0500
Refactor FXIOS-7324 [v121.1] Add missing credit card option for FxA syncing in the choose what to sync list (#17678)
* Refactor FXIOS-7324 [v121] Add missing credit card option for FxA syncing in the choose what to sync list
* Added credit card feature flag as part of it as well
commit ef1db1d3927c09488c33bf2c8222205200d15a11
Author: imsanchit <sanchitmittal18@gmail.com>
Date: Thu Dec 14 22:03:48 2023 +0530
Bugfix FXIOS-7055 [v122] Add spacer to "use saved card" button (#17589)
commit b872bb325aa4e294fb7c64586da25c5bb81a4c87
Author: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>
Date: Thu Dec 14 16:34:21 2023 +0100
Refactor FXIOS-7950 [v122] Do not restore bottom sheet on iPhone (#17727)
commit ada0be9c7bfdb603918088bd3249180415dec423
Author: PARAIPAN SORIN <51127880+PARAIPAN9@users.noreply.github.com>
Date: Thu Dec 14 16:24:08 2023 +0200
Add FXIOS-7912 [v122] Display the same ad if bottom sheet is closed and reopened again (#17699)
* Cache ads from review checker
* Fix indentation
* Rename shoudFetchAds var
* make ProductAdsCache an actor
* Adjust tests for concurrency
* Use guard instead of if
commit 397bea560a242f8824b11a2dbfe2187b3231f8ad
Author: roux g. buciu <11182210+adudenamedruby@users.noreply.github.com>
Date: Wed Dec 13 15:50:19 2023 -0500
Refactor FXIOS-7663 [v122] String updates and reorg (#17752)
* Some ideas have arisen in my head about organization
* Move old strings to make things easier
* More updates
* More strings updated
* More more more!
* Strings will be the end of me
* Guess what - I updated strings
* Further updates
* Increasing the update count
* The final commit... hopefully
* It was not the final commit
* L10N comments
* Fixie da tests!
* I'm not sure what's happening
---------
Co-authored-by: roux g. buciu <github@fringe.foundation>
commit 3da38427bdb56807ed4376cbd8b7fb4d2d258f9d
Author: Cyndi Chin <cgc95@cornell.edu>
Date: Wed Dec 13 13:02:00 2023 -0500
Add FXIOS-7192 [v122] Private mode homepage card link (#17750)
* Add FXIOS-7191 [v122] Private mode homepage card link
* update tests
* remove whitespace
* revert chopping
commit 1157f0b845b61239fa5a0e04246763a432fdcf31
Author: yoanarios <yriosdiaz@mozilla.com>
Date: Wed Dec 13 10:22:13 2023 -0500
Bugfix FXIOS-7946 [v122] FxA signin using QR code gets dismissed before finishing the flow (#17745)
commit 2e6b12ff3ea4dcd2e322597eda12f04d9442eb98
Author: dragosb01 <134391433+dragosb01@users.noreply.github.com>
Date: Wed Dec 13 14:11:26 2023 +0200
Fix MTE-1946 [v122] testOpenTabsInSearchSuggestions smoke test (#17728)
commit 59da1e82949c0fa370c1f0cefdff9789e8ac3bdc
Author: Litianu Razvan <litianu.razvan@gmail.com>
Date: Wed Dec 13 10:24:40 2023 +0200
Add FXIOS 7838 [v122] Call ads events recording api when user sees ad product (#17730)
* FXIOS-7802 #17400 Call ads events recording API when user taps on ad product
* Change request for different events
* Update tests
* FXIOS-7838 #17492 Call ads events recording API when user sees ad product
commit 75b54affc484462f3fc8346304c23a6f1fb9ba91
Author: mattreaganmozilla <145381717+mattreaganmozilla@users.noreply.github.com>
Date: Tue Dec 12 12:44:39 2023 -0800
Refactor FXIOS-7931 [v122] Window manager unit tests & more early refactors (#17712)
* [7931] Additional early refactors to WindowManager for iPad multi-window, and adding unit tests
* [7931] Fix SwiftLint warning
* [7931] Add logging per PR feedback, new log category for iPad multiwindow messages, some minor refactors
* [7931] Ensure AppContainer is reset in new unit tests for WindowManager
commit a3d1e674010016e12e76c0a94ee6ff5dc62688b1
Author: Itunu Raimi <chavitunu@gmail.com>
Date: Tue Dec 12 21:34:37 2023 +0100
Refactor FXIOS-7673 [v122] Remove SnapKit from SearchViewController (#17420)
* remove snapkit contraint from SearchViewController on BrowserViewController
* replace snapkit with NSLayoutConstraint on SearchViewController
* fix issue with searchBar and searchEngines not showing
* fix issue with dismissing keyboard constraint
commit 3ec7840dd9a2ee31806b19b5f96701ab6788ec9b
Author: FilippoZazzeroni <55580351+FilippoZazzeroni@users.noreply.github.com>
Date: Tue Dec 12 21:32:23 2023 +0100
BugFix FXIOS-7942-7943 [v122] QRCodeViewController not presented in LegacyTabTray and in MainMenuActionHelper(#17733)
Co-authored-by: Filippo Zazzeroni <f.zazzeroni@hidonix.com>
commit ca83fd7780bf438c9f0ed2dce55a9770444016b7
Author: imsanchit <sanchitmittal18@gmail.com>
Date: Wed Dec 13 01:17:05 2023 +0530
Bugfix FXIOS-5683 [v122] Learn more link not readable with large dynamic type (#17713)
commit ee169b88a7844d0a5575560f3c253739fab35306
Author: yoanarios <yriosdiaz@mozilla.com>
Date: Tue Dec 12 14:20:39 2023 -0500
Bugfix FXIOS-6943 [v122] Listen for updates to the state from the tab tray view controller (#17709)
commit de16add42094791717730854dfc9ed525aca688f
Author: mattreaganmozilla <145381717+mattreaganmozilla@users.noreply.github.com>
Date: Tue Dec 12 09:10:16 2023 -0800
Bugfix FXIOS-7836 [v122] Recently-closed tabs: fix encoding/decoding (#17719)
* [7836] NSSecureCoding conformity
* [7836] Fix several issues with encoding and decoding of ClosedTab
commit 48c1dd18ab5761da186af30a11a91c8357c8210f
Author: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>
Date: Tue Dec 12 17:08:21 2023 +0100
Refactor FXIOS-7839 [v122] Change ad image loading view to show default image (#17698)
* Add image
* Show default image
* Load product image
* Remove unused view
* Add a11y ids to images
* Move image loading to model
* Scale default image according to dynamic type preference
* Remove completion
commit b5ef3250a1727808619d2dcd8cffd0b686a2b273
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Tue Dec 12 10:54:46 2023 -0500
Refactor [v122] Auto update SPM with latest rust-component 122.0.20231212050319 (#17732)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit 4200209cd3283c57a5a2ca3bfc3001ec0a990f9b
Author: Cyndi Chin <cgc95@cornell.edu>
Date: Tue Dec 12 08:42:52 2023 -0500
Add FXIOS-7187 [v122] New private homepage for felt privacy (#17704)
* Add FXIOS-7187 [v122] New private homepage for felt privacy
* remove unnecessary code and update test
commit 6b93fa1f3d944645f49d2c1f5a5c2d2c967eb104
Author: Litianu Razvan <litianu.razvan@gmail.com>
Date: Tue Dec 12 15:08:49 2023 +0200
Add FXIOS-7802 [v122] Call ads events recording API when user taps on ad product (#17682)
* FXIOS-7802 #17400 Call ads events recording API when user taps on ad product
* Change request for different events
* Update tests
commit de5cb29292a1c731a1a8de5ef4ea1683f0602cfc
Author: dragosb01 <134391433+dragosb01@users.noreply.github.com>
Date: Tue Dec 12 13:33:11 2023 +0200
Add MTE-1993 [v122] delete credit card test (#17701)
commit f7cc5440eff68fffb5a360e6044597266f2f5853
Author: lmarceau <lmarceau@mozilla.com>
Date: Mon Dec 11 17:15:21 2023 -0500
Remove [v122] Remove unused import SnapKit (#17711)
commit ecbb6e3c71fb7206677fe9daa24c40ad1877909f
Author: Marceau TONELLI <marceau.tonelli@epitech.eu>
Date: Mon Dec 11 20:13:42 2023 +0100
Refactor FXIOS-7699 [v122] Continue migration by using UIButton.Configuration in PrimaryRoundedButton (#17616)
* Renamed ResizableButton to LegacyResizableButton
* Added a new ResizableButton class using UIButton.Configuration
* Added new helper function to set a button's font through configuration
The way to set the font using UIButton.Configuration is pretty verbose so this helper function will help reduce code duplication once migrating the rest of the codebase
* Updated PrimaryRoundedButton to use the new ResizableButton class
* Updated PrimaryRoundedButton usage in FirefoxAccountSignInViewController
Using `withRenderingMode(.alwaysTemplate)` on the button's image so it gets tinted like the button's title when highlighted, interpolating from the base colour.
(This fixes a bug where the theme was not being properly taken into account in the signin page. If the button was highlighted when using dark mode, the image was white instead of dark)
* Updated usage of PrimaryRoundedButton in DefaultBrowsingOnboardingViewController
Added an extension `NSDirectionalEdgeInsets.init(equalInset:)` based on the existing one for `UIEdgeInsets`
* Auto stash before merge of "feature/migrate-primarybutton-to-uibutton-configuration" and "upstream/main"
* Revert accidental changes commited to Package.resolved
* Remove unnecessary NSDirectionalEdgeInsets extension
* Match update of configuration with LinkButton for concistency
* Use textInverted for all states of PrimaryRoundedButton
* Cleanup setting updated configuration
* Added a comment to tell that extension is only a temporary fix
commit 112c6acacc73a71660ee17d19109b0b9b1ef1500
Author: mattreaganmozilla <145381717+mattreaganmozilla@users.noreply.github.com>
Date: Mon Dec 11 11:02:28 2023 -0800
Refactor FXIOS-7931 [v122] Additional early refactors for iPad multi-window (#17691)
* [7931] Initial work to stub out a central window manager for forthcoming iPad multiwindow. Related refactors and cleanup.
* [7931] Clean up and remove previous fix for openRecentlyClosedSiteInNewTab, in favor of using new window manager to ask for the active window
* [7931] Fix crash in unit test, AppContainer must be registered with protocol type, not concrete implementation
commit 4603ab91877bca591f3064b301b141ea7e6c40e9
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Mon Dec 11 11:39:41 2023 -0500
Localize [v122] String import 2023-12-11 (#17700)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit 8b7a6292bbd03e9e35fb162ecd004d88bc169965
Author: Mihai Bolojan <74779930+bmihai23@users.noreply.github.com>
Date: Mon Dec 11 16:33:42 2023 +0200
Refactor FXIOS-7886 [v122] Fix kUTTypeText and kUTTypeURL deprecations (#17614)
* Resolve deprecations in iOS 15.0 for kUTTypeText and kUTTypeURL
* Remove unnecessary String casting
---------
Co-authored-by: Mihai Bolojan <mihaibolojan@Mihais-MacBook-Pro.local>
commit 412a103f4b15d5d1e6dd2e05bb2ff7be22eaf7ea
Author: imsanchit <sanchitmittal18@gmail.com>
Date: Mon Dec 11 15:39:10 2023 +0530
Bugfix FXIOS-17027 [v122] Autofill Credit Cards input fields are not labeled programmatically (#17464)
* issue-17027 | added accessiblity label on text field
* issue-17027 | Autofill Credit Cards input fields are not labeled programmatically
commit b842d9c525a6f1b69ef9c752de36100739978ed4
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Mon Dec 11 10:41:43 2023 +0100
Auto update SPM with latest rust-component release 122.0.20231209050318 (#17693)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit 6d9685e704e3a168905bbc5050f553021408f447
Author: mattreaganmozilla <145381717+mattreaganmozilla@users.noreply.github.com>
Date: Fri Dec 8 13:52:46 2023 -0800
Refactor FXIOS-7808 [v122] Refactors to AppEvent for window UUIDs and iPad multi-window support (#17661)
* [7808] Update AppEvent to work for multiple iPad windows, also add several related refactors to provide early preparations for when we have multiple windows enabled. Provide a UUID on the scene and tabManager associated with an individual window.
* [7808] Minor cleanup for readability
* [7808] Comment cleanup
* [7808] Fix unit tests, updates to initializers for mock tab managers
* [7808] Fix warning, discardable result
* [7808] Rename event associated with BVC updates run as part of appDidBecomeActive
* [7808] Clean up ToDo comments
* [7808] Fix unused result warnings
* [7808] Cleanup arg
* [7808] Fix unit test
commit 56534636f0a179569579cbc6028c6a5faf552755
Author: lmarceau <lmarceau@mozilla.com>
Date: Fri Dec 8 16:21:27 2023 -0500
Remove FXIOS-7926 [v122] Remove Tab.isRestoring as it's always false anyway (#17686)
commit 3b6eca3873996a7e8d5981d85d8c9c5809888f00
Author: OrlaM <omitchell@mozilla.com>
Date: Fri Dec 8 13:44:51 2023 -0500
Refactor FXIOS-7869 [v122] Rename TabPeek to legacy (#17683)
commit 335d2fa38070534f784e957df78c97e2f9c6145a
Author: roux g. buciu <11182210+adudenamedruby@users.noreply.github.com>
Date: Fri Dec 8 13:34:07 2023 -0500
Refactor FXIOS-7913 [v122] Simplify BVCState (#17685)
* First pass
* More updates
---------
Co-authored-by: roux g. buciu <github@fringe.foundation>
commit f1f2a3495081a418ed124090aed4a1def5361ef4
Author: yoanarios <yriosdiaz@mozilla.com>
Date: Fri Dec 8 13:18:27 2023 -0500
Refactor FXIOS-6942 [v122] Listen for updates to the state from the sync tabs view controller (#17653)
commit 1e9ddfca1febfc1956a779be8d2031374264ef41
Author: mattreaganmozilla <145381717+mattreaganmozilla@users.noreply.github.com>
Date: Fri Dec 8 08:56:34 2023 -0800
Refactor FXIOS-7914 [v122] Update DependencyHelperMock, fix unit test dependency crash
commit 29429a348e33fba15e5ce8fb2f8dd5a8e57d90a0
Author: lmarceau <lmarceau@mozilla.com>
Date: Fri Dec 8 11:28:34 2023 -0500
Add FXIOS-7793 [v122] Add basic WKEngineSession (#17654)
* First pass on WKEngineSession
* Move tests to proper target
* Fix tests
* Fix comment + add a11y commented code for reference + clean up webserver (renaming it to avoid confusion)
* Fix swiftlint
commit 6e0a7934fde81957517c6bfc2708b4ec46cfe2b3
Author: lmarceau <lmarceau@mozilla.com>
Date: Fri Dec 8 11:09:55 2023 -0500
Refactor FXIOS-7891 [v122] Clean up if available code (#17655)
commit 684a7ad245fff6575cce978c3cfd935e9b3fd628
Author: Mark Hammond <mhammond@skippinet.com.au>
Date: Fri Dec 8 11:01:38 2023 -0500
Remove FXIOS-7882 [v122] Remove support for sqlcipher, sqlcipher migrations and very old sqlites (#17598)
commit 3515ea1e649b83bc2211fd83ff2397092828b6dc
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Fri Dec 8 10:58:55 2023 -0500
Refactor [v122] auto update credential provider script (#17582)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit c141bf19753755f3718efe7edd70427542cf709d
Author: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>
Date: Fri Dec 8 16:39:14 2023 +0100
Refactor FXIOS-7694 [v122] Add FR/DE supported retailer domains to product URL detection (#17667)
commit 828b91b652fcad3397b4a4f766ebd258c7b54ac9
Author: Marceau TONELLI <marceau.tonelli@epitech.eu>
Date: Fri Dec 8 16:10:51 2023 +0100
Bugfix FXIOS-7530 [v122] Fix UnsafeRawPointer warnings for objc_setAssociatedObject (#17620)
commit be71e1834d310f53254f826fbd5ef0541c3f65d4
Author: PARAIPAN SORIN <51127880+PARAIPAN9@users.noreply.github.com>
Date: Fri Dec 8 16:39:17 2023 +0200
Add FXIOS-7753 [v122] Telemetry for SurfaceNoAdsAvailable (#17663)
* Add metric for surfaceNoAdsAvailable event
* Add PR to data reviews
* Change indentation and remove data sensitivity from metrics
commit 73c121eb0ec2b1f582f554740fba1a55a919cb7b
Author: Daniela Arcese <dnarcese@gmail.com>
Date: Thu Dec 7 13:31:58 2023 -0500
Add FXIOS-7909 [v121] Add messaging trigger for 3 days since install (#17657)
commit 77c6ffa5cd677d91f2ceaed0cad6e7c5e1e40289
Author: lmarceau <lmarceau@mozilla.com>
Date: Thu Dec 7 10:21:52 2023 -0500
Refactor FXIOS-7904 [v122] Clean up url extensions (#17658)
* Clean up some of the URLExtensions
* Fix tests
commit 5b1a6f744a4eb4b34d65a5500cd707347bad926d
Author: NSOiO <swiftwithlove@163.com>
Date: Thu Dec 7 10:15:11 2023 -0500
Refactor FXIOS-6079 [v122] Change folder to cache for safelistFileURL (#17633)
* fix: FXIOS-6079 #13761 change file from document to cache for safelistFileURL
* fix review issues, add log
commit b12cb3295638ec022348d0abf943d2ee1b3ced4d
Author: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>
Date: Thu Dec 7 16:08:11 2023 +0100
Refactor FXIOS-7890 [v122] Review Checker's advertised products' price should be formatted with "$", not "USD" prefix (#17636)
* Add price formatter
* Display the formatted price
* Address PR comment
commit 9c48c746c86d273220f2f010afe98fd22bcc6444
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Wed Dec 6 14:00:49 2023 -0500
Refactor [v122] Auto update SPM with latest rust-component 122.0.20231206050313 (#17637)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit e69f0eaa36b9d78e983942710788aa2e0184356c
Author: mattreaganmozilla <145381717+mattreaganmozilla@users.noreply.github.com>
Date: Wed Dec 6 09:58:49 2023 -0800
Refactor FXIOS-7845 [v122] Remove shared TabManager, use dependency injection (#17607)
* [7845] Refactor shared global TabManager out of AppContainer, instead use individual instances passed via DI, one for each BVC. For currently iOS app this should have no change, but it helps pave the way for forthcoming multiwindow support for iPad.
* [7845] Minor cleanup, unused import
* Fix several SwiftLint warnings
* [7845] Update unit tests for changes to various initializers which now require passing in TabManager via DI
* [7845] Inject TabManager into HomepageSettingVC. This also should fix one of the failing UI tests.
commit 464dd51a936b1c9e2514fbb711febe162f2e90c7
Author: jhugman <jhugman@users.noreply.github.com>
Date: Wed Dec 6 17:27:25 2023 +0000
Refactor EXP-4109 [v121] Add string-alias types to messaging and onboarding FML files (#17588)
* Refactor EXP-3675 [v121] Add string-alias to messaging feature
* Refactor EXP-3675 [v121] Add string alias to onboarding feature
commit 6ec11447b3cc220a7b3c1b8fdb4586e11ff0322a
Author: dragosb01 <134391433+dragosb01@users.noreply.github.com>
Date: Wed Dec 6 18:53:21 2023 +0200
Add MTE-1948 [v122] Access Credit cards section test (#17615)
commit 1a0317331f5c8f36167ab24200f9f6965d76ec24
Author: PARAIPAN SORIN <51127880+PARAIPAN9@users.noreply.github.com>
Date: Wed Dec 6 18:52:56 2023 +0200
Bugfix FXIOS-7880 [v121] Save/Update Login Snackbar - White buttons and white text (#17625)
* Conform to Themeable
* Correct spelling
* Remove conformance to Themeable
commit 717c77db22bcd3083f1f10a89cec0737fb6ee78d
Author: lmarceau <lmarceau@mozilla.com>
Date: Wed Dec 6 11:24:35 2023 -0500
Remove FXIOS-7248 [v122] Remove send to device delegate from homepage, not used anymore (#17613)
* Remove send to device delegate from homepage, not used anymore
* Remove unused funciton in BVC
commit e8dd7773e46f45d09551f02598f167676b6d22ff
Author: Michael Kaply <345868+mkaply@users.noreply.github.com>
Date: Wed Dec 6 11:06:58 2023 -0500
Refactor FXIOS-7684 [v121] Update Amazon engines and remove out of contract ones (#17522)
commit 6f96f757404a1641bdc4f36dd89247e596c50632
Author: imsanchit <sanchitmittal18@gmail.com>
Date: Wed Dec 6 21:10:33 2023 +0530
Bugfix FXIOS-6879 [v122] Fixed reading order for bottom sheet credit card (#17630)
commit 26658bb847b47e7b44f24aa4b07d1546e688794a
Author: Litianu Razvan <litianu.razvan@gmail.com>
Date: Wed Dec 6 13:35:28 2023 +0200
Add FXIOS-7257 [v122] Fetch recommended/ad product image via OHTTP (#17634)
commit 924a44f970976f217bb64622757a1f784446cddd
Author: Marceau TONELLI <marceau.tonelli@epitech.eu>
Date: Wed Dec 6 12:34:50 2023 +0100
Refactor FXIOS-7713 [v122] Remove legacy theme manager usage from BookmarksFolderCell (#17622)
- Return plain image with rendering mode `.alwaysTemplate` instead of two tinted variants based on theme
- Apply `tintColor` on image view instead, in the cell's `applyTheme` method
commit d816c47ca9909da8ab573e415008ed263c3e1f6b
Author: Litianu Razvan <litianu.razvan@gmail.com>
Date: Wed Dec 6 11:01:54 2023 +0200
Add FXIOS-7801 [v122] Add ads events recording API endpoint (#17617)
* FXIOS-7801 #17399 Add ads events recording API endpoint
* swiftlint fix
commit 75da8ec3385f2d51263b2c74f55b0eeebf779c51
Author: yoanarios <yriosdiaz@mozilla.com>
Date: Tue Dec 5 14:05:19 2023 -0500
Refactor FXIOS-7858 [v122 ]Add support for inactive tabs actions in middleware and listen for updates (#17608)
* Create file for LegacyInactiveTabModel
* Support inactive tabs actions
* Fix test and add unit test for getInactive tabs new interface
* Use defaultTabManager on middleware
* Fix swiftlint warning
commit 638fa77f7eb1d0871c6d1cffb8f62fb5e7cf06ef
Author: lougeniaC64 <lougeniaC64@users.noreply.github.com>
Date: Tue Dec 5 13:52:22 2023 -0500
Add FXIOS-7790 [v122] New metric for logins keychain data loss (#17381)
commit acc00f3039fbae0d9e2d5803353ba2cac6cbb818
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Tue Dec 5 10:56:37 2023 -0500
Refactor [v122] Auto update SPM with latest rust-component 122.0.20231205050341 (#17621)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit 9caeb7e6b0b7d036117420044b33189b7408dad6
Author: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>
Date: Tue Dec 5 16:47:49 2023 +0100
Refactor FXIOS-7857 [v122] Make Learn more link in FakespotReviewQualityCardView taller (#17597)
* Use LinkButtonViewModel for learn more
* Apply theme correctly
* Set the button color using configuration
* Fix build error in sample library
commit f8565a9a19a9e5ba48b8e5e6fac7c1a5eba9cba4
Author: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>
Date: Tue Dec 5 16:24:21 2023 +0100
Refactor FXIOS-7812 [v121] Fakespot - iPad - sidebar open/close state resets itself when user changes from landscape to portrait mode (#17587)
* Dismiss sidebar when opting out
* Dismiss sidebar when tapping not now
* Use state to dismiss and show Fakespot
* Dismiss Fakespot when startAtHome
* Use iPad sidebar state
* Update Fakespot when user navigates using the back/forward buttons
* Update Fakespot when user navigates using the back/forward buttons
* Update Fakespot actions
* Open and close fakespot via state change
* Fix bugs related to deep-linking
* Fix test
* Address PR comments
* Fix merge issues
* Fix Swiftlint warning
commit 451e22bee8a7263d0aaee1eac1646179eec9bbf2
Author: lmarceau <lmarceau@mozilla.com>
Date: Tue Dec 5 09:34:48 2023 -0500
Refactor FXIOS-7883 [v122] Move contextual id away from sponsored tile telemetry (#17610)
commit 50778aba268f50f56b95e324b52c4d66b7da0b03
Author: roux g. buciu <11182210+adudenamedruby@users.noreply.github.com>
Date: Tue Dec 5 09:00:43 2023 -0500
Add FXIOS-7302 [v122] Swiftlint: closure_parameter_position (#17606)
* Add swiftlint rule
* Fix warnings
* empty line
---------
Co-authored-by: roux g. buciu <github@fringe.foundation>
commit 9b67b4375f27011c164b5ee5b972b01ea1775687
Author: PARAIPAN SORIN <51127880+PARAIPAN9@users.noreply.github.com>
Date: Tue Dec 5 10:36:59 2023 +0200
Add FXIOS-7754 [v122] Add telemetry for SurfaceAdsImpression (#17524)
* Implement handling of view visibility
* Add glean metric
* Ad PR to data reviews and remove print statements
* Send telemetry event only once
* Rename two properties
commit 69d918338e76af55ed4266166eea1f9c2c71809a
Author: FilippoZazzeroni <55580351+FilippoZazzeroni@users.noreply.github.com>
Date: Tue Dec 5 01:00:46 2023 +0100
Add FXIOS-6507 [v122] show of QRCodeViewController from QRCodeCoordinator to production code (#17563)
* Add show of QRCodeViewController from QRCodeCoordinator to production code
* Add QRCodeDismissHandler to foreward dismiss from the QRCodeViewController to the QRCodeCoordinator.
Refactor QRCodeCoordinatorTests.
* Refactor some typos
* Refactor as per code review, Turn on QRCodeCoordinatorRefactor feature.
---------
Co-authored-by: Filippo Zazzeroni <f.zazzeroni@hidonix.com>
commit 47b688374ea1714b113dae7bcb024b12af06bd0b
Author: Cyndi Chin <cgc95@cornell.edu>
Date: Mon Dec 4 16:58:06 2023 -0500
Remove FXIOS-7865 [v122] Unused function in homepageVC (#17603)
commit e3c6635b7887af8507ea6c8310a42ef281d4a261
Author: roux g. buciu <11182210+adudenamedruby@users.noreply.github.com>
Date: Mon Dec 4 15:59:12 2023 -0500
Add FXIOS-7303 [v122] Swiftlint: closure spacing (#17594)
* Fix some tests
* Autocorrects
* Autocorrect autocorrected too hard?
---------
Co-authored-by: roux g. buciu <github@fringe.foundation>
commit eeb2b5358e5641eaf7475ff88d7bae24489aa06c
Author: roux g. buciu <11182210+adudenamedruby@users.noreply.github.com>
Date: Mon Dec 4 15:29:08 2023 -0500
Refactor FXIOS-7188 [v122] Update felt privacy strings to new versions (#17560)
* Add strings
* Add another string
* update tag
* Missed string
* Update Client/Frontend/Strings.swift
Co-authored-by: Cyndi Chin <cgc95@cornell.edu>
* add felt deletion
* My swiftlint child has defeated me
---------
Co-authored-by: roux g. buciu <github@fringe.foundation>
Co-authored-by: Cyndi Chin <cgc95@cornell.edu>
commit 46e5132eca417094287d7f960983abeea067810b
Author: roux g. buciu <11182210+adudenamedruby@users.noreply.github.com>
Date: Mon Dec 4 15:28:45 2023 -0500
Refactor FXIOS-7187 [v122] Rename Felt Privacy variable (#17604)
Co-authored-by: roux g. buciu <github@fringe.foundation>
commit e39d437b2364eb0e89151f41471686a45f5c06e4
Author: jnrahme <jnrahme@gmail.com>
Date: Mon Dec 4 14:28:35 2023 -0500
Refactor FXIOS-7864 [v122] Renaming and refactor of CreditCardHellper (#17573)
* Renaming and refactor of CreditCardHellper
* comments
* swiftlint
commit 70f365871ea0d63f177b39c61fb7b418efa9cc6a
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Mon Dec 4 13:31:58 2023 -0500
Refactor [v122] Auto update SPM with latest rust-component 122.0.20231202050335 (#17581)
* Auto update SPM with latest rust-component release 122.0.20231202050335
* Fix DeviceType parameter (#17592)
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bendk <bdk@mozilla.com>
commit db030442f42c7efc732d6bb8d10442011e89240e
Author: mattreaganmozilla <145381717+mattreaganmozilla@users.noreply.github.com>
Date: Mon Dec 4 10:21:59 2023 -0800
Refactor FXIOS-7863 [v122] Remove TabManagerMiddleware dependency on global TabManager (#17575)
* [7863] Very early WIP to remove dependency on global TabManager instance for Redux. This area of the code is in flux and may be changing soon.
* [7863] Minor cleanup, remove private since it wasnt in place in previous code
* Add ticket number to ToDO
* Ensure redux dispatch is gated behind feature flag
* Fix SwiftLint warning
* [7863] Refactors, move code for connecting TabMgr out of SceneCoordinator and into BrowserCoordinator init instead, this fixes some of the related unit tests and should be cleaner. Aspects of this are still in flux. WIP
* Rename func for consistency
commit 307357d41f4a80a6f9f6784778751d3c87158f1d
Author: Marceau TONELLI <marceau.tonelli@epitech.eu>
Date: Mon Dec 4 19:18:22 2023 +0100
Refactor FXIOS-7699 [v122] Start migration to using UIButton.Configuration for buttons styling (#17585)
* Renamed ResizableButton to LegacyResizableButton
* Added a new ResizableButton class using UIButton.Configuration
* Set warnings threshold to 77 in generate-metrics
commit 723d77f29d69ba1296fbb66cbf97c34befc8a9a5
Author: roux g. buciu <11182210+adudenamedruby@users.noreply.github.com>
Date: Mon Dec 4 13:04:22 2023 -0500
Refactor FXIOS-7817 [v122] Add BrowserViewControllerState (#17565)
* Lots of learning
* Updates & cleanup
* Remove things
* Minor refactor lolololololol
* Language and big brain fixes
* PR comments
---------
Co-authored-by: roux g. buciu <github@fringe.foundation>
commit 296e39f234a05bc22a3af149d4bd1198369400ed
Author: mattreaganmozilla <145381717+mattreaganmozilla@users.noreply.github.com>
Date: Mon Dec 4 09:42:14 2023 -0800
Bugfix FXIOS-7875 [v122] Empty Private tabs: fade-in animation
commit 69e65b8c01f99ba95e5c5d515a8ac3d20abb7707
Author: OrlaM <omitchell@mozilla.com>
Date: Mon Dec 4 09:56:55 2023 -0500
Bugfix FXIOS-7874 [v120] homepage crash (#17577)
* Fix top sites crash
* Fix tests
commit be67b16aea8a120e73c4cc6fa42a0ec796d2aced
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Mon Dec 4 09:41:24 2023 -0500
Localize [ver] String import 2023-12-04 (#17586)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit b0bab2452be3f1366ad605f30d82993181d9eddf
Author: NSOiO <daition340@163.com>
Date: Mon Dec 4 04:21:49 2023 -0500
Bugfix FXIOS-7568 [v122] Close button on the onboarding screen is not the first focusable element (#17525)
* add accessibility extension
* Bugfix #16842 make close button the first focusable element on the onboarding screen
* modify the doc
* add accessibility unit test
* modify the accessibility unit test
* fix swiftlint warnings & errors
* reveret previous changes for FXIOS-7568
* fix #16842, use close button as the first focusable element.
* replace force unwrapping
commit 437283fb158794ac5078f90c6022aab7b99db5ba
Author: lmarceau <lmarceau@mozilla.com>
Date: Fri Dec 1 16:10:01 2023 -0500
Refactor [v122] Clean up telemetry + lower warnings threshold (#17552)
* Clean up
* Fix empty data review in storage metrics yaml
* Lowering the warnings threshold
* Fix unit tests warnings and error
* fix warnings
commit 89277e8d52f567b1b2559d9e57667322403accf9
Author: Ryan VanderMeulen <rvandermeulen@mozilla.com>
Date: Fri Dec 1 12:00:32 2023 -0500
Bump [v122] Update Sentry to version 8.17.1 (#17564)
commit f4249463b33f6ad9382d8510e77bc8be63e4c1bb
Author: Adam Felix <adam.tyler.felix@protonmail.com>
Date: Fri Dec 1 11:17:19 2023 -0500
Add FXIOS-7408 [v122] Implement UILargeContentViewer and related protocols for URL bar, tab bar and tab location view (#17473)
commit 6a092ccedce90d56ef3240b8652ffa0f234199ab
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date: Fri Dec 1 11:07:03 2023 -0500
Refactor [v122] Auto update SPM with latest rust-component 122.0.20231201050257 (#17562)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit 12ea4c97023576a96c676fe93edc63dcb27a14a4
Author: Callie Dunn <q2r5@live.com>
Date: Fri Dec 1 10:18:57 2023 -0500
Bugfix FXIOS-7854 [v122] Widgets have a white or black outline (pa…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
This PR refactors our current global
TabManagerto be dependency-injected instead of using the shared instance inAppContainer. It is part of the early prep work for forthcoming updates to support multiple windows on iPad.👉 This is a pure refactor and should have no impact to current functionality on
main.Context
As part of iPad multiwindow we will need to support multiple browsers running side by side. This creates challenges in areas where we have previously used shared global state that would otherwise be unique to an individual window. BrowserViewController is an example, and was already refactored not long ago so that each scene in the iOS app has a unique instance. This PR follows a similar pattern for the
TabManager. Because each window will be managing its own unique set of normal & private tabs it's necessary to support separate manager instances per BVC/coordinator.Multiwindow support is a WIP. More changes forthcoming; notably the Telemetry code will need to be updated. However in this PR everything with telemetry should continue to work as expected.
📝 Checklist
You have to check all boxes before merging