Skip to content

Remove SwiftyJSON Dependency #6885

Closed
Closed
@nbhasin2

Description

Remove the SwiftyJSON dependency as iOS JSON parsing is good enough that we don't really need SwiftyJSON which hasn't been updated in a while. The following files has SwiftyJSON imports:

  • SyncAuthState.swift
  • TokenServerToken.swift
  • PushClient.swift
  • PushRegistrationAPI.swift
  • PushRemoteError.swift
  • PushRegistration.swift
  • JSONExtensions.swift
  • Functions.swift
  • KeychainCache.swift
  • KeychainStore.swift
  • NetworkUtils.swift
  • RemoteDevices.swift
  • Clients.swift
  • SyncQueue.swift
  • SQLiteHistoryFavicons.swift
  • SQLiteRemoteClientsAndTabs.swift
  • ClientsSynchronizer.swift
  • HistorySynchronizer.swift
  • Info.swift
  • SyncMeta.swift
  • State.swift
  • EnvelopeJSON.swift
  • EncryptedJSON.swift
  • CleartextPayloadJSON.swift
  • KeysPayload.swift
  • ClientPayload.swift
  • HistoryPayload.swift
  • LoginPayload.swift
  • TabsPayload.swift
  • SyncTelemetryUtils.swift
  • Keys.swift
  • StorageClient.swift
  • SyncTelemetry.swift
  • FxATelemetryTests.swift
  • SyncCommandsTests.swift
  • Mocking.swift
  • MockSyncServer.swift
  • HistorySyncronizerTests.swift
  • InfoTests.swift
  • MetaGlobalTests.swift
  • RecordTests.swift
  • BatchingClientTests.swift
  • StorageClientTests,swift

It seems not all files with import use SwiftyJSON. First task is to clean up imports of SwiftyJSON. Then we can create subsequent task to remove SwiftyJSON in particular files.

┆Issue is synchronized with this Jira Task

Metadata

Assignees

No one assigned

    Labels

    Contributor OKThis is a good issue for contributors interested in helping the projectTechnical ImprovementRefactor or update parts of code to make better to manage

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions